-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update the position of the tooltip and set it near the label text #12779
base: dev
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
src/components/FindWallet/WalletTable/WalletMoreInfoCategory.tsx
Outdated
Show resolved
Hide resolved
@@ -87,20 +88,19 @@ export const WalletMoreInfoCategory = ({ | |||
<ListIcon as={FeatureIcon}></ListIcon> | |||
|
|||
<Text px={1} lineHeight={1}> | |||
{feature.label} | |||
{feature.label} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In either case, I would stick with either the non-breaking space, or the margin (ms="2"
below) but not both... I'm still not sure of a clean way to do this for all browsers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Dharmik79 Just checking in... you still willing/able to help with this, or would you prefer someone to try and take it from here?
Description
Added the tooltip inside the feature label text and made the list item aligned horizontally
Related issue