-
-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Confused about DispatchMessageQueue() and different order of OnClose/OnMessage in the latest version #67
Comments
Also, I'm getting some messages in a different order. Specifically, it seems that previously I was able to disconnect and reconnect a player and sync any lost messages (which I cache locally on both the server and the client), and now I receive a disconnect event a bit sooner than expected (and I suppose there might be other subtle differences). I suppose several other things changed, not only when OnMessage() is called, as I also tried to call OnMessage manually, to closely match the old way, but issues still happen.
and this is the current one in this repo:
Is there any obvious change that could lead to my issue? |
Hi @tfgstudios, this change on the library has been introduced since this PR #11, IIRC this new threading mechanism was due to extra unnecessary delays happening on the previous implementation when receiving messages. I think you are right regarding the order of "close" and message events that differ after this release. The I've flagged this issue as a bug, please let me know if you have any luck fixing this! |
Hey, I was only able to fix it on the user side. There were other issues (Unity's own ones) in the play, so I'm not sure which fixed which. |
Hi, I recently updated to the latest version and I realized OnMessage is not being called anymore.
I've spent several hours debugging and, by mistake, discovered this DispatchMessageQueue() method, which is not called by anyone.
Did I just have a very old version where this method was automatically called? I don't find the text "DispatchMessageQueue" anywhere throughout any of the involved projects, so it means in my last version it was called automatically, internally.
I really looked among your release notes before upgrading and such a breaking change wasn't mentioned anywhere..
Was my version just an ancient one (like before 1.0.0)? Just trying to understand what happened.
Very useful library, BTW. Thanks!
The text was updated successfully, but these errors were encountered: