Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Websockets OnClose doesn't contain the close message #50

Open
Esildor opened this issue Aug 26, 2021 · 1 comment
Open

Websockets OnClose doesn't contain the close message #50

Esildor opened this issue Aug 26, 2021 · 1 comment
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@Esildor
Copy link

Esildor commented Aug 26, 2021

When a websocket closes, they contain a reason for close, additionally they contain a message. Currently this libraries OnClose delegate just emits the reason enum and not a message too.
@j1mmie
Copy link

j1mmie commented Jan 28, 2023

It also does not support sending back user-defined status codes during the closing handshake. Instead, NativeWebSocket passes an undefined WebSocketCloseCode to the event listener :(

More about user-defined status codes here: https://www.rfc-editor.org/rfc/rfc6455#section-7.4.2

@endel endel added bug Something isn't working help wanted Extra attention is needed labels Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@endel @j1mmie @Esildor