We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
eframe::run_native takes a closure that creates the user's application. We should have some way of returning errors from it.
eframe::run_native
It already has a rather complicated signature:
pub type AppCreator = Box<dyn FnOnce(&CreationContext<'_>) -> Box<dyn App>>;
And that would need to become something like
type DynError = Box<dyn std::error::Error>; pub type AppCreator = Box<dyn FnOnce(&CreationContext<'_>) -> Result<Box<dyn App>>, DynError>;
…unless we can come up with something nicer.
In Rerun we initialize the renderer in the app creation callback, and that can fail because of missing features of the host GPU.
The text was updated successfully, but these errors were encountered:
Improve error message when using an under-powered GPU (#6252)
efba98a
### What Using `scripts/fetch_crashes.py` to look at our analytics, I noticed that missing wgpu capabilities would lead to a assert/panic, which is not a nice way to report errors to users. I added an egui issue to improve this further in the future: * emilk/egui#4474 ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested the web demo (if applicable): * Using examples from latest `main` build: [rerun.io/viewer](https://rerun.io/viewer/pr/6252?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) * Using full set of examples from `nightly` build: [rerun.io/viewer](https://rerun.io/viewer/pr/6252?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG * [x] If applicable, add a new check to the [release checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)! - [PR Build Summary](https://build.rerun.io/pr/6252) - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html) To run all checks from `main`, comment on the PR with `@rerun-bot full-check`.
No branches or pull requests
eframe::run_native
takes a closure that creates the user's application. We should have some way of returning errors from it.It already has a rather complicated signature:
And that would need to become something like
…unless we can come up with something nicer.
Motivation
In Rerun we initialize the renderer in the app creation callback, and that can fail because of missing features of the host GPU.
The text was updated successfully, but these errors were encountered: