Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to winit 0.30 #4437

Open
emilk opened this issue Apr 30, 2024 · 5 comments · May be fixed by #4466
Open

Update to winit 0.30 #4437

emilk opened this issue Apr 30, 2024 · 5 comments · May be fixed by #4466
Labels
eframe Relates to epi and eframe egui-winit porblems related to winit help wanted Extra attention is needed

Comments

@emilk
Copy link
Owner

emilk commented Apr 30, 2024

Also needed:

@emilk emilk added help wanted Extra attention is needed eframe Relates to epi and eframe egui-winit porblems related to winit labels Apr 30, 2024
@emilk emilk added this to the Next Major Release milestone Apr 30, 2024
@mwcampbell
Copy link
Contributor

The accesskit_winit update for winit 0.30 is released now.

@lylythechosenone
Copy link

Updating to wgpu 0.20.0 should be an important goal here as well. Not sure if that should be a separate issue.

@torokati44
Copy link
Contributor

That's already done: #4433

@AndriBaal
Copy link

I updated winit to 0.30.0 and was able to successfully run the hello-world example successfully with wgpu.

Here is a summary of the changes I made:

  • Bump accesskit to version 0.14.0
  • Bump winit to 0.30.0
  • Partially done the glow integration
  • Roughly implemented accesskit
  • Implemented winit / wgpu

Here is a summary of things that need to be done:

  • Integration with glow. We have to wait until glutin-winit updates to winit 0.30.0
  • Not all accesskit_winit::Event are being processed, temporarily I have marked them with todo! (found in winit_integration.rs)
  • Move from deprecated winit::EventLoop::run_on_demand to new Application trait
  • Documentation and testing
  • Code review

I have madew a pull request with my changes here: #4466

@emilk emilk linked a pull request May 6, 2024 that will close this issue
@mwcampbell
Copy link
Contributor

You can see how to properly handle all the accesskit_winit events in this branch that I never got around to completing and submitting as a PR because, at the time, updating accesskit_winit led to cargo deny problems in CI. That problem is solved now, so feel free to take code from my branch, including my changes to the egui crate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
eframe Relates to epi and eframe egui-winit porblems related to winit help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants