Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Help! Code Reviewers & Contributors Wanted! #589

Open
mhendric opened this issue Mar 7, 2019 · 0 comments
Open

Help! Code Reviewers & Contributors Wanted! #589

mhendric opened this issue Mar 7, 2019 · 0 comments
Labels
discussion The issue is a discussion. help wanted The issue is up for grabs for anyone in the community. high priority The issue or PR should be resolved first. It is of less priority than the label 'Blocking Release'.

Comments

@mhendric
Copy link
Contributor

mhendric commented Mar 7, 2019

Sending a request out to the community for help with performing code reviews on Pull Requests in this repository. Code reviewers of all skill sets are welcome. Review what you can, and if you think a second set of eyes is warranted via an additional review, just say so.

Here's some general guidelines and suggestions:

  • Keep an eye out for Pull Requests that have the 'needs review' label
  • If you are beginning a review on someone's Pull Request, add a comment in the PR saying you are doing so.
  • Be familiar with the DSC Resource Style Guidelines & Best Practices, and be able to identify when the Style Guidelines aren't being followed.
  • Be familiar with what is asked of contributers in the PULL REQUEST TEMPLATE
  • Keep an eye out for scenarios where new Integration or Unit tests could be warranted (i.e. if a bug is fixed that could have been tested for, but no tests yet exist).
  • Try to keep your review scoped to the actual changes being made (i.e. try not to request style changes on surrounding code that is not being modified as part of the PR). There's a lot of ongoing cleanup work on this module that still needs to be completed, but in most cases, those can be handled in separate Issues. Feel free to call out or open an Issue if surrounding code needs to be adjusted though, just don't make it a blocker.

Thanks!

@mhendric mhendric added help wanted The issue is up for grabs for anyone in the community. discussion The issue is a discussion. high priority The issue or PR should be resolved first. It is of less priority than the label 'Blocking Release'. labels Mar 7, 2019
@mhendric mhendric pinned this issue Mar 7, 2019
@SteveL-MSFT SteveL-MSFT added this to High Priority in powershell/dscresources May 14, 2019
@SteveL-MSFT SteveL-MSFT removed this from High Priority in powershell/dscresources Nov 27, 2019
@PlagueHO PlagueHO changed the title Help! Code Reviewers Wanted! Help! Code Reviewers & Contributors Wanted! Jul 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion The issue is a discussion. help wanted The issue is up for grabs for anyone in the community. high priority The issue or PR should be resolved first. It is of less priority than the label 'Blocking Release'.
Projects
None yet
Development

No branches or pull requests

1 participant