Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

making container fluid to fix #53 #54

Merged
merged 1 commit into from
Aug 14, 2019
Merged

making container fluid to fix #53 #54

merged 1 commit into from
Aug 14, 2019

Conversation

gaelcolas
Copy link
Member

@gaelcolas gaelcolas commented Aug 14, 2019 •
edited by johlju

Hey team, here's an attempt to fix #53
I'm using bootstrap container-fluid class (instead of container).

Let me know if you prefer that.

This change is Reviewable

@raandree
Copy link
Contributor

That looks way better!

@gaelcolas
Copy link
Member Author

you might just have a weird resolution, knowing your "laptop". 😏
What do you think @johlju & @PlagueHO ?

@johlju
Copy link
Member

johlju commented Aug 14, 2019

Yeah I think is looks good. Merging this.

johlju
johlju approved these changes Aug 14, 2019
View reviewed changes
Copy link
Member

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we feel this is ugly in some places, we can just make a layout/template for those pages that uses container.

@johlju johlju merged commit 1207247 into master Aug 14, 2019
@johlju johlju deleted the fix/#53 branch August 14, 2019 16:01
@johlju
Copy link
Member

johlju commented Aug 14, 2019

Hmm, I actual tested this on my laptop and in an RDP session with lower resolution, and thought it looked okay. But on a large screen 2400> this messes up the other parts of the site. I will revert this change and I think we need to make a template for just the blog section.

johlju added a commit that referenced this pull request Aug 14, 2019
@johlju
Revert "making container fluid to fix #53 (#54)"
1c2b2c2 
This reverts commit 1207247.
@johlju johlju mentioned this pull request Aug 14, 2019
Merged
johlju added a commit that referenced this pull request Aug 14, 2019
@johlju
Revert "making container fluid to fix #53 (#54)" (#55)
1e2b6f8 
This reverts commit 1207247.
@gaelcolas
Copy link
Member Author

hum, who does look at a website on a very large screen without splitting? maybe we can add a max width...?

@johlju
Copy link
Member

johlju commented Aug 14, 2019 •
edited

@gaelcolas the blog section, style guideline and community notes could use the fluid

@johlju
Copy link
Member

johlju commented Aug 14, 2019

Well, probably many ;)

@johlju
Copy link
Member

johlju commented Aug 14, 2019

Max width could work. 🤔

@johlju
Copy link
Member

johlju commented Aug 14, 2019

We used a separate template for maintainers, so easy enough to add template for the sections we need more width on. 🤔
https://github.com/dsccommunity/dsccommunity.org/blob/master/layouts/community/maintainers.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johlju johlju johlju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Blog pages are rendered too narrow
3 participants
@gaelcolas @raandree @johlju