Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change languages to String array type in UpdateServicesServer Get-TargetResource return value #77

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Change languages to String array type in UpdateServicesServer Get-TargetResource return value #77

wants to merge 3 commits into from

Conversation

jortencio
Copy link

@jortencio jortencio commented Jul 18, 2023 •
edited

Pull Request (PR) description

Updates the returned value for the languages value in the return value for UpdateServicesServer Get-TargetResource function

This Pull Request (PR) fixes the following issues

Fixes #76

Task list

  • Added an entry under the Unreleased section of the change log in the CHANGELOG.md.
    Entry should say what was changed, and how that affects users (if applicable).
  • Resource documentation added/updated in README.md.
  • Resource parameter descriptions added/updated in README.md, schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Resource Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
  • New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

This change is Reviewable

@jortencio jortencio changed the title Change languages to String array type in Get-TargetResource return value Change languages to String array type in UpdateServicesServer Get-TargetResource return value Jul 18, 2023
@NicolasBn
Copy link
Member

Hello @jortencio thanks for your contribution.
Can you complete the CHANGELOG.md file ?

@johlju johlju added the waiting for code fix A review left open comments, and the pull request is waiting for changes to be pushed by the author. label Sep 26, 2023
@jortencio
Copy link
Author

Hi @NicolasBn , I have updated the CHANGELOG.md file as requested to reflect the changes in this PR.

@NicolasBn
Copy link
Member

Hi @jortencio thank you for your change.
In your issue @sooyean-hoo referenced the same issue with Products collection. Can you add this fix in your PR? And maybe added some pester tests to cover your changes?

@jortencio
Copy link
Author

Hi @NicolasBn as requested I have added pester tests to cover my changes. Regarding the products collection, I had a brief look and there doesn't seem to be an issue with the implementation for it.

@johlju johlju added needs review The pull request needs a code review. and removed waiting for code fix A review left open comments, and the pull request is waiting for changes to be pushed by the author. labels Nov 1, 2023
@johlju johlju requested a review from NicolasBn November 1, 2023 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicolasBn NicolasBn Awaiting requested review from NicolasBn

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
needs review The pull request needs a code review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UpdateServicesServer: Incorrect Type for Language in return value for Get-TargetResource
3 participants
@jortencio @NicolasBn @johlju