Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpticalDiskDriveLetter: Fix finding drive on Azure Windows Server 2022 #275

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

OpticalDiskDriveLetter: Fix finding drive on Azure Windows Server 2022 #275

wants to merge 2 commits into from

Conversation

tj-spyro
Copy link

@tj-spyro tj-spyro commented May 23, 2023 •
edited by PlagueHO

Pull Request (PR) description

Added support for changing optical disk drive letter on Windows Server 2022 where the DeviceId appears to be longer than 10 characters in length.

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Resource documentation added/updated in README.md.
  • Resource parameter descriptions added/updated in README.md, schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Community Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Community Testing Guidelines.
  • New/changed code adheres to DSC Community Style Guidelines.

This change is Reviewable

@codecov
Copy link

codecov bot commented May 23, 2023 •
edited

Codecov Report

Merging #275 (3db5666) into main (4a9e4fa) will increase coverage by 0%.
The diff coverage is 100%.

Impacted file tree graph

@@         Coverage Diff         @@
##           main   #275   +/-   ##
===================================
  Coverage    95%    95%           
===================================
  Files         7      7           
  Lines       882    889    +7     
===================================
+ Hits        842    849    +7     
  Misses       40     40
Impacted Files Coverage Δ
...calDiskDriveLetter/DSC_OpticalDiskDriveLetter.psm1 93% <100%> (+<1%) ⬆️

@johlju johlju added the needs review The pull request needs a code review. label Sep 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PlagueHO PlagueHO Awaiting requested review from PlagueHO

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
needs review The pull request needs a code review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OpticalDiskDriveLetter: The optical disk 1 could not be found in the system on Azure Windows Server 2022
2 participants
@tj-spyro @johlju