Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OfficeOnlineServerFarm: InternalURL should not be mandatory #42

Open
shurick81 opened this issue Apr 30, 2019 · 1 comment · May be fixed by #65
Open

OfficeOnlineServerFarm: InternalURL should not be mandatory #42

shurick81 opened this issue Apr 30, 2019 · 1 comment · May be fixed by #65

Comments

@shurick81
Copy link

Details of the scenario you tried and the problem that is occurring

I am trying to build a farm, similar to what MS describes in the very first example: https://docs.microsoft.com/en-us/powershell/module/officewebapps/new-officewebappsfarm?view=officewebapps-ps

In this example, InternalURL is not specified, because only ExternalURL is in use.

Verbose logs showing the problem

Suggested solution to the issue

Change parameters validation

The DSC configuration that is used to reproduce the issue (as detailed as possible)

            OfficeOnlineServerFarm Farm
            {
                ExternalURL                 = "https://$($mainParameters.OOSHostName)"
                EditingEnabled              = $true
                CertificateName             = $mainParameters.OOSHostName
                LogLocation                 = $logFolder
                CacheLocation               = "$workingFolder\d"
            }

The operating system the target node is running

Win 2019

Version and build of PowerShell the target node is running

5.1

Version of the DSC module that was used ('dev' if using current dev branch)

1.2

@ykuijs
Copy link
Member

ykuijs commented May 6, 2019

The InternalURL property is specified as the Key property and therefore is always mandatory. To allow the above scenario, we need a new property.

Isn't the IsSingleInstance property better here:
https://docs.microsoft.com/en-us/powershell/dsc/resources/singleinstance

A farm should only be created once on a server, so there should only be one instance of this property per server. The same is true for OfficeOnlineServerMachine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants