MSFT_OfficeOnlineServerProductUpdate creates new farms on multiple servers

[ThomasLie]

Details of the scenario you tried and the problem that is occurring

When installing a CU for Office Online Server farm (2 servers) using the ressource MSFT_OfficeOnlineServerProductUpdate it creates new farms on each server.

The operating system the target node is running

Windows Server 2019 64bit DE-DE with language pack EN-US
Office Online Server 2019 EN-US with language pack DE-DE

Version and build of PowerShell the target node is running

5.1

Version of the DSC module that was used

1.5.0

[hebbea]

I have the same problem. Will try to look at it when i get time.

[ThomasLie]

Well, I think I found the cause for this..

In resource MSFT_OfficeOnlineServerProductUpdate in function Set-TargetResource, line 279 the resource tries to get the new master machine:
$patchedMachines = $serversInfo | Where-Object -FilterScript { $_.Version -eq $PatchVersion }

The variable $serversInfo (see line 238, never gets updates after patch install on any of the farm servers.
This means, that the resource will set the current server as the new master machine everytime.

To resolve this, the variable $serversInfo has to be updated after a patch has been installed successfully in order to get the correct product version.

The current code should be changed to:

# Determine new MasterMachine (one of the already patched servers) $serversInfo = Get-ServerInfo -Servers $Servers $patchedMachines = $serversInfo | Where-Object -FilterScript { $_.Version -eq $PatchVersion }

Do you agree?