Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BREAKING CHANGE: OfficeOnlineServerFarm: Added 'IsSingleInstance' parameter #65

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

BREAKING CHANGE: OfficeOnlineServerFarm: Added 'IsSingleInstance' parameter #65

wants to merge 6 commits into from

Conversation

JonasCassier
Copy link
Contributor

@JonasCassier JonasCassier commented Nov 6, 2023 •
edited

Pull Request (PR) description

Adds the parameter 'IsSingleInstance' as suggested in #42.

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Resource documentation added/updated in README.md.
  • Resource parameter descriptions added/updated in README.md, schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Community Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Community Testing Guidelines.
  • New/changed code adheres to DSC Community Style Guidelines.

This change is Reviewable

@codecov Codecov
Copy link

codecov bot commented Nov 6, 2023

Codecov Report

Merging #65 (24b9088) into master (7358992) will increase coverage by 0%.
The diff coverage is 98%.

Impacted file tree graph

@@         Coverage Diff          @@
##           master   #65   +/-   ##
====================================
  Coverage      80%   80%           
====================================
  Files           6     6           
  Lines         759   766    +7     
====================================
+ Hits          613   620    +7     
  Misses        146   146
Files Coverage Δ
...eOnlineServerFarm/MSFT_OfficeOnlineServerFarm.psm1 95% <98%> (+<1%) ⬆️

@johlju johlju added the needs review The pull request needs a code review. label Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs review The pull request needs a code review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OfficeOnlineServerFarm: InternalURL should not be mandatory
2 participants
@JonasCassier @johlju