Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cluster: Improve error message when login fails #158

Open
johlju opened this issue Nov 22, 2017 · 0 comments
Open

Cluster: Improve error message when login fails #158

johlju opened this issue Nov 22, 2017 · 0 comments
Labels
enhancement The issue is an enhancement request. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub help wanted The issue is up for grabs for anyone in the community.

Comments

@johlju
Copy link
Member

johlju commented Nov 22, 2017

Details of the scenario you tried and the problem that is occurring:
When line 368 fails it should be more clear in the error message what domain the user, that failed to login, belonged to.
Today only the username is written in the error message, making it difficult to know if the credentials that was passed was correct.

Example error message:

System.InvalidOperationException: Can't logon as user test123.

https://github.com/PowerShell/xFailOverCluster/blob/76f6de5cdba7368753f1a67fc6ca34f735e64bf5/DSCResources/MSFT_xCluster/MSFT_xCluster.psm1#L368-L380

Error string:
https://github.com/PowerShell/xFailOverCluster/blob/76f6de5cdba7368753f1a67fc6ca34f735e64bf5/DSCResources/MSFT_xCluster/en-US/MSFT_xCluster.strings.psd1#L19

The DSC configuration that is using the resource (as detailed as possible):
n/a

Version of the Operating System and PowerShell the DSC Target Node is running:
n/a

Version of the DSC module you're using, or 'dev' if you're using current dev branch:
Dev

@johlju johlju added enhancement The issue is an enhancement request. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub help wanted The issue is up for grabs for anyone in the community. easy fix labels Nov 22, 2017
@johlju johlju removed the easy fix label May 7, 2018
@SteveL-MSFT SteveL-MSFT added this to Help Wanted in powershell/dscresources May 14, 2019
@SteveL-MSFT SteveL-MSFT removed this from Help Wanted in powershell/dscresources Nov 27, 2019
@johlju johlju changed the title xCluster: Improve error message when login fails Cluster: Improve error message when login fails Jun 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement The issue is an enhancement request. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub help wanted The issue is up for grabs for anyone in the community.
Projects
None yet
Development

No branches or pull requests

1 participant