Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CertificateImport: Remove non-mandatory parameter Ensure from the Get-TargetResource function #144

Open
johlju opened this issue Jul 20, 2018 · 1 comment
Open

CertificateImport: Remove non-mandatory parameter Ensure from the Get-TargetResource function #144

johlju opened this issue Jul 20, 2018 · 1 comment
Labels
enhancement The issue is an enhancement request. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub help wanted The issue is up for grabs for anyone in the community.

Comments

@johlju
Copy link
Member

johlju commented Jul 20, 2018

Details of the scenario you tried and the problem that is occurring:
In the resource CertificateImport there should be no need to have the non-mandatory parameter Ensure in the Get-TargetResource function.

https://github.com/PowerShell/CertificateDsc/blob/6906fc5b31a783a899260c9c9d4ba84a02dd4c14/Modules/CertificateDsc/DSCResources/MSFT_CertificateImport/MSFT_CertificateImport.psm1#L65-L68

The DSC configuration that is using the resource (as detailed as possible):
n/a

Version of the Operating System and PowerShell the DSC Target Node is running:
n/a

Version of the DSC module you're using, or 'dev' if you're using current dev branch:
Dev
@johlju johlju added enhancement The issue is an enhancement request. help wanted The issue is up for grabs for anyone in the community. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub labels Jul 20, 2018
@johlju
Copy link
Member Author

johlju commented Jul 20, 2018

@PlagueHO you raised an issue with this, it would be a breaking change for Chef and Ansible users? I just saw code that could be removed 🙂

@SteveL-MSFT SteveL-MSFT added this to Help Wanted in powershell/dscresources May 14, 2019
@SteveL-MSFT SteveL-MSFT removed this from Help Wanted in powershell/dscresources Nov 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement The issue is an enhancement request. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub help wanted The issue is up for grabs for anyone in the community.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@johlju