Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ActiveDirectoryDsc: Use New-CimCredentialInstance for credential objects #430

Open
johlju opened this issue Jul 13, 2019 · 0 comments
Open

ActiveDirectoryDsc: Use New-CimCredentialInstance for credential objects #430

johlju opened this issue Jul 13, 2019 · 0 comments
Labels
enhancement The issue is an enhancement request. help wanted The issue is up for grabs for anyone in the community.
Projects
All issues and PR's

Comments

@johlju
Copy link
Member

johlju commented Jul 13, 2019

We should use the same pattern as in xADDomainTrust to return the credential objects from Get-TargetResource.

https://github.com/PowerShell/xActiveDirectory/blob/dd53b43a46a6e7ddd101a0b7f393af0d377b100e/DSCResources/MSFT_xADDomainTrust/MSFT_xADDomainTrust.psm1#L60-L66

The helper function New-CimCredentialInstance will create a MSFT_Credential CIM instance credential object without a password that can be used to return the actual username used from GetTargetResource.

This should be used for all resource that have a MSFT_Credential instance in the schema.mof.
@johlju johlju added enhancement The issue is an enhancement request. help wanted The issue is up for grabs for anyone in the community. labels Jul 13, 2019
@johlju johlju added this to To do in All issues and PR's via automation Jul 13, 2019
@johlju johlju changed the title xActiveDirectory: Use New-CimCredentialInstance for credential objects ActiveDirectoryDsc: Use New-CimCredentialInstance for credential objects Jul 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement The issue is an enhancement request. help wanted The issue is up for grabs for anyone in the community.
Projects
All issues and PR's
  
To do
Milestone
No milestone
Development

No branches or pull requests
1 participant
@johlju