-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Authentication failed issue #18586
Comments
@trains78 Can you please update to the latest (being 3.3.17) and let us know if you are still having issues? |
Thanks for the issue @trains78. This should be fixed in the latest release of GitHub Desktop. Could you please try holding down |
Thank you for the quick response. We are still having this issue with one of our developers after taking the suggested steps ![image](https://github.com/desktop/desktop/assets/169380912/71903d7e-f633-49be |
Just to make sure I understand: You have 19 devs that can access the same repositories that is failing for the one on 3.3.17? If so could you make sure that that user is using a valid PAT and try to authenticate again. |
I have started to see this today with 3.3.17 when trying to push to a self-hosted Gogs repo on localhost. I've never had any problems doing that until today (multiple years of use, many times per day). I've had to switch to doing By contrast, pushing to our private Github repos is all fine. Looking at the release history, I can't be sure whether I was using 3.3.15 or 3.3.16 before I noticed the upgrade announcement and clicked on it this evening, but I am 100% on 3.3.17 now. I see this issue has some history, so apologies if I've posted in the wrong place 😊 This might help:
|
This comment has been minimized.
This comment has been minimized.
Is there anyone can fix this ? |
At least one. I haven’t had all update just yet. The ones that have greater than 3.3.14 have this issue. Created new PAT. Uninstalled / Reinstalled. Cloned repo again. Issue remains. |
@poblish I see that you're using repositories over unencrypted http, we fixed a regression related to this scenario in #18589 and we've released it to our beta channel. Could you please try installing our beta version from https://desktop.github.com/beta/ and try again? @herobrinePerssion Could you please open a new issue and provide some more details and a log file? Before doing so please make sure you've also updated to the latest beta version from https://desktop.github.com/beta/. @trains78 We fixed a few bugs in rapid succession in 3.3.16 and 3.3.17. If the issue persist for users on 3.3.17 please have one of them open a new issue and include a log file so that we can investigate. Thanks! |
I have the same problem (with Azure DevOps). Is there a way to install/download an older version of github-desktop? |
@RoHeck What version of GitHub Desktop are you on right now? If it's 3.3.17 could you please The log files are created daily -- please upload a log file as an attachment from a day where you experienced the issue. Thanks! |
@niik Just downloaded Version 3.3.18-beta1 (x64) and the situation is unchanged there. |
@poblish could you share the new logs with 3.3.18-beta1, please? 🙏 Thank you! |
Sure - this is from performing a Fetch on my repo:
git version 2.45.0 |
@poblish only looking at the log this looks like a legitimate auth failure. I know you said that there's no username involved there but the host at http://localhost:3000 is requesting credentials and that's why Desktop is asking you. I'm afraid I'm not familiar with Gogs but could you double check your configuration to see if it is set up to require credentials? |
Well, yes, If I run |
@poblish GitHub Desktop has never run the default credential helper so there's no change there. What has happened though is that due to a change in how we store credentials (and an oversight related to servers running on non-standard ports) your instance has "forgotten" the credentials previously stored for your Gogs server. If you enter the correct credentials again Desktop will store them and not ask you for them again. |
Thanks @niik. I reauthenticated once in Desktop, and everything is now working as before. I'm back on 3.3.17 and all is well. |
@poblish I'm glad to hear that. Thanks for reporting back and sorry for the inconvenience! |
Since updating to 3.3.17 today it has complained numerous times about authentication. All for the same repository, in Azure DevOps. I did notice it started asking for credentials a lot more frequent in the past couple of months compared to before but today it has happened excessively. I don't think credentials expire in a matter of few hours though... It is also hard to reproduce "on demand" because it happens randomly and there is nothing special that needs to be done other than doing a simple Fetch. |
This has been our experience as well. When it happens again, I will post the logs. |
Looking at the logs, I can see that the errors do not come from the repository that I'm doing the Fetch on but for the other repos that are cloned locally. So you do a Fetch on repo X and apparently it just tries to refresh credentials for repo Y and presents you with the popup.
|
For context, there is a periodic fetch of all repos that happens on an interval and if authentication fails there it will not show you a popup nor error, but it will log the error. Thus, likely that is what you are seeing in your logs. |
No, I'm afraid this is not currently the case. Just a few seconds ago I clicked Fetch on the open repo and the login popup appeared. I opened the log and I found authentication errors for 3 unrelated repos at around the current timestamp. I smell something here... I think the periodic refresh that's supposed to work in the background somehow "spills" into the UI and is causing the login popup to appear. |
Interesting. Any chance you have submodules? |
Sorry for the blog. It’s against the rules you know. |
Hello 👋 Please, try the latest beta (3.3.19-beta2) from https://desktop.github.com/beta which includes support for multiple git credentials on the same host based on different repository paths and let us know if it works. After updating, you might need to re-enter your credentials for your Azure DevOps repositories. For hosts other than
Thank you for your patience 🙏 |
With 3.3.19-beta2 still unable to connect to OCI DevOps Repository on 'https://devops.scmservice.eu-amsterdam-1.oci.oraclecloud.com' . Works on 3.3.14 with Cleaned my Windows Credentials and have tried
|
@Airell could you share your log files, please? 🙏 |
so far so good, will keep an eye on this |
I reverted back to 3.3.14, updated to the 3.3.19-beta2 again to collect logs, but now it seems to work... 🤔 |
@sergiou87 I just checked out your the comment you referenced in the other thread. So if I understand correctly:
If that's the case, I will try it out next week when I'm on my work laptop again :) Thank you! |
Yes, that should be the case 🤞🤞🤞 Please, let us know if it works qhen you try it! Thank you for your patience 💖 |
This is looking good. I've tried many combinations of different repos in the same Org, in different Orgs, etc Ship it! 🚢🚢🚢 |
Thank you for your feedback @Gabriel-Lacatus 🙇♂ We're still investigating some issues reported on this beta. We think they're not related to the fix we introduced, but we want to be sure before promoting it to production. |
I am having this issue in I thought the contractor I had working on it had messed something up, but I made a brand new repo and can't clone that either. It prompts for username and password with a mention of a PAT. My UN/PW doesn't work and my UN/PAT doesn't work. A previously cloned repo will not accept pushes and gives the authentication failed message with the bulletted list,. not the UN/PW options. Github Desktop is signed into Github.com in the Accounts section of Github Desktop Options. I have tried logging out and back in - no change. |
Still an issue for me on 3.3.18 on macos to connect to azure devops, is 3.3.19 coming out soon? |
@yechenchao @Gabriel-Lacatus @Airell You can download 3.4.0 now from https://desktop.github.com (auto-updates are rolled out progressively and might take longer) Closing this now, thank you for your patience 🙏 |
This is still not working for me on 3.41 that was just released. 3.4 did not work as well. I am still running 3.3.17 which is the latest version that would allow us to commit without this error. |
This is still not working for me on 3.4.1 :( |
Same issue 3.4.1 |
Having this issue also on 3.4.1 |
Fixed it on my side - this might help some I think the issue of many might be coming from the fact that once you try to Push again, for some reason GitHub Desktop asks you to re-enter the Password, and this is where the confusion might be coming from Some might be using the username/password, some a Token key that is not valid anymore, etc. So once you try to enter the [wrong] password, GitHub Desktop then won't ask you again for the Password anymore, only prompting with the Failed Auth popup message So what you have to do is go to your 'Windows Credidential Manager', remove the one associated with your repo URL then GitHub Desktop will ask you again to enter the Password when trying to Push Now make sure to Regenerate your Token, and enter this one when asking the Password, and it should work correctly now |
👋 we just shipped GitHub Desktop 3.4.2-beta2 to our beta channel. This includes support for using Git Credential Manager. It's currently off by default but you can enable it in Settings under the advanced tab. We believe this will address the authentication problems outlined in this issue. When Git Credential Manager (GCM) is enabled all credentials for third-party (i.e. Azure Devops, BitBucket, GitLab etc) will be handled, and stored, outside of GitHub Desktop. GCM supports browser-sign in to many popular services and will avoid the need to create personal access tokens (PATs). Please download our beta version from https://desktop.github.com/beta/ to give this a go and please report back with your experience. We'll be collecting feedback in our beta channel which will inform when we make this available to all users. Installing the beta version will not clear your preferences or tracked repositories and you can switch to the production version by simply downloading the latest version from https://desktop.github.com. |
This comment has been minimized.
This comment has been minimized.
It worked! Thank you so much! |
It's working, thank you very much. |
The problem
Github Dekstop updated to 3.3.15 and is now asking for credentials to fetch everytime. We use Azure DevOps repo with Personal access tokens. Anyone on our team with 3.3.14 is not having this issue. We receive the following error everytime even when updating the access token on Azure.
Release version
3.3.15
Operating system
Windows 11
Steps to reproduce the behavior
Fetch any repo from private repo on Azure Devops
Log files
2024-05-09.desktop.production.log
Screenshots
Additional context
Have about 20 members on the team and anyone who has version 3.3.15 and up of Github Desktop is having this issue. Anyone with 3.3.14 is not.
The text was updated successfully, but these errors were encountered: