Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dmGameSystem::RenderBoxNodes crashed sometimes when change atlas #8785

Closed
d954mas opened this issue Apr 11, 2024 · 1 comment · Fixed by #8945
Closed

dmGameSystem::RenderBoxNodes crashed sometimes when change atlas #8785

d954mas opened this issue Apr 11, 2024 · 1 comment · Fixed by #8945
Assignees
@Jhonnyg
Labels
bug Something is not working as expected engine Issues related to the Defold engine gui Issues related to gui components

Comments

@d954mas
Copy link
Contributor

d954mas commented Apr 11, 2024

Describe the bug (REQUIRED)
Sometimes i get crash if try to replace atlas with liveupdate content.

I tryed to make small reprocase to show it.

Crash happened sometimes. I use build 5-10 times and see crash

NFO:DLIB: Log server started on port 54123
INFO:ENGINE: Target listening with name: LAPTOP-K0DFPU0P - fe80::747e:3b65:904b:5c9a - Windows
INFO:ENGINE: Engine service started on port 54124
INFO:GRAPHICS: Installed graphics device 'ADAPTER_FAMILY_OPENGL'
INFO:ENGINE: Defold Engine 1.7.0 (bf4dc66)
INFO:DLIB: Initialized Remotery (ws://127.0.0.1:17815/rmt)
INFO:ENGINE: Loading data from: build/default
INFO:ENGINE: Initialised sound device 'default'
DEBUG:SCRIPT: proxy loaded:[main:/game#proxy]
INFO:DLIB: SSDP: Started on address 192.168.0.103
INFO:DLIB: SSDP: Started on address 192.168.56.1
DEBUG:SCRIPT: proxy loaded:[main:/liveupdate#proxy]
INFO:CRASH: Successfully wrote Crashdump to file: C:\Users\user\AppData\Roaming\Defold/_crash
ERROR:CRASH: CALL STACK:

ERROR:CRASH:  0 0x7FF6A168E470 dmCrash::GenerateCallstack D:\a\defold\defold\engine\crash\src\backtrace_win32.cpp:144
ERROR:CRASH:  1 0x7FF6A1784CFC _seh_filter_exe minkernel\crts\ucrt\src\appcrt\misc\exception_filter.cpp:219
ERROR:CRASH:  2 0x7FF6A17C9954 `__scrt_common_main_seh'::`1'::filt$0 D:\a\_work\1\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl:304
ERROR:CRASH:  3 0x7FF6A1705F4C __C_specific_handler D:\a\_work\1\s\src\vctools\crt\vcruntime\src\eh\riscchandler.cpp:389
ERROR:CRASH:  4 0x7FFE1E492290 __chkstk <unknown>:0
ERROR:CRASH:  5 0x7FFE1E441030 RtlRaiseException <unknown>:0
ERROR:CRASH:  6 0x7FFE1E490E90 KiUserExceptionDispatcher <unknown>:0
ERROR:CRASH:  7 0x7FF6A134AC50 dmGameSystem::RenderBoxNodes D:\a\defold\defold\engine\gamesys\src\gamesys\components\comp_gui.cpp:1443
ERROR:CRASH:  8 0x7FF6A134D810 dmGameSystem::RenderNodes D:\a\defold\defold\engine\gamesys\src\gamesys\components\comp_gui.cpp:2016
ERROR:CRASH:  9 0x7FF6A1684050 dmGui::RenderScene D:\a\defold\defold\engine\gui\src\gui.cpp:1561
ERROR:CRASH: 10 0x7FF6A1347880 dmGameSystem::CompGuiRender D:\a\defold\defold\engine\gamesys\src\gamesys\components\comp_gui.cpp:2296
ERROR:CRASH: 11 0x7FF6A12FFBE0 dmGameObject::Render D:\a\defold\defold\engine\gameobject\src\gameobject\gameobject.cpp:2664
ERROR:CRASH: 12 0x7FF6A1368320 dmGameSystem::CompCollectionProxyRender D:\a\defold\defold\engine\gamesys\src\gamesys\components\comp_collection_proxy.cpp:336
ERROR:CRASH: 13 0x7FF6A12FFBE0 dmGameObject::Render D:\a\defold\defold\engine\gameobject\src\gameobject\gameobject.cpp:2664
ERROR:CRASH: 14 0x7FF6A12DED40 dmEngine::StepFrame D:\a\defold\defold\engine\engine\src\engine.cpp:1663
ERROR:CRASH: 15 0x7FF6A12DFAA0 dmEngineUpdate D:\a\defold\defold\engine\engine\src\engine.cpp:2177
ERROR:CRASH: 16 0x7FF6A12DFCD0 dmEngine::RunLoop D:\a\defold\defold\engine\engine\src\engine_loop.cpp:83
ERROR:CRASH: 17 0x7FF6A12D7F40 engine_main D:\a\defold\defold\engine\engine\src\engine_main.cpp:148
ERROR:CRASH: 18 0x7FF6A16FA344 __scrt_common_main_seh D:\a\_work\1\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl:288
ERROR:CRASH: 19 0x7FFE1DAF7330 BaseThreadInitThunk <unknown>:0
ERROR:CRASH: 20 0x7FFE1E442690 RtlUserThreadStart <unknown>:0
ERROR:CRASH: 

INFO:CRASH: Successfully wrote Crashdump to file: C:\Users\user\AppData\Roaming\Defold/_crash
ERROR:CRASH: CALL STACK:

ERROR:CRASH:  0 0x7FF6A134AC50 dmGameSystem::RenderBoxNodes D:\a\defold\defold\engine\gamesys\src\gamesys\components\comp_gui.cpp:1443
ERROR:CRASH:  1 0x7FF6A134D810 dmGameSystem::RenderNodes D:\a\defold\defold\engine\gamesys\src\gamesys\components\comp_gui.cpp:2016
ERROR:CRASH:  2 0x7FF6A1684050 dmGui::RenderScene D:\a\defold\defold\engine\gui\src\gui.cpp:1561
ERROR:CRASH:  3 0x7FF6A1347880 dmGameSystem::CompGuiRender D:\a\defold\defold\engine\gamesys\src\gamesys\components\comp_gui.cpp:2296
ERROR:CRASH:  4 0x7FF6A12FFBE0 dmGameObject::Render D:\a\defold\defold\engine\gameobject\src\gameobject\gameobject.cpp:2664
ERROR:CRASH:  5 0x7FF6A1368320 dmGameSystem::CompCollectionProxyRender D:\a\defold\defold\engine\gamesys\src\gamesys\components\comp_collection_proxy.cpp:336
ERROR:CRASH:  6 0x7FF6A12FFBE0 dmGameObject::Render D:\a\defold\defold\engine\gameobject\src\gameobject\gameobject.cpp:2664
ERROR:CRASH:  7 0x7FF6A12DED40 dmEngine::StepFrame D:\a\defold\defold\engine\engine\src\engine.cpp:1663
ERROR:CRASH:  8 0x7FF6A12DFAA0 dmEngineUpdate D:\a\defold\defold\engine\engine\src\engine.cpp:2177
ERROR:CRASH:  9 0x7FF6A12DFCD0 dmEngine::RunLoop D:\a\defold\defold\engine\engine\src\engine_loop.cpp:83
ERROR:CRASH: 10 0x7FF6A12D7F40 engine_main D:\a\defold\defold\engine\engine\src\engine_main.cpp:148
ERROR:CRASH: 11 0x7FF6A16FA344 __scrt_common_main_seh D:\a\_work\1\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl:288
ERROR:CRASH: 12 0x7FFE1DAF7330 BaseThreadInitThunk <unknown>:0
ERROR:CRASH: 13 0x7FFE1E442690 RtlUserThreadStart <unknown>:0
ERROR:CRASH: 

INFO:CRASH: Successfully wrote MiniDump to file: C:\Users\user\AppData\Roaming\Defold/_crash.dmp

To Reproduce (REQUIRED)
See repro case.

I think something happened if i load liveupdate and game collection in parallel.(this is hypothesis)

go.property("atlas", resource.atlas("/assets/skins.atlas"))

function init(self)


	timer.delay(1, false, function()
		factory.create("/factories#factory1",vmath.vector3(480-100,170,0))
		factory.create("/factories#factory2",vmath.vector3(480,170,0))
		factory.create("/factories#factory3",vmath.vector3(480+100,170,0))
	end)
	msg.post("/game#proxy", "async_load")
	msg.post("/liveupdate#proxy", "async_load")
end

function on_message(self, message_id, message, sender)
	if message_id == hash("proxy_loaded") then
		print("proxy loaded:" .. sender)
		msg.post(sender, "enable")
	end

end

Expected behavior (REQUIRED)
Engine not crashed if i change atlas

Defold version (REQUIRED):

  • Version 1.7.0

Platforms (REQUIRED):

  • Platforms: Windows

Minimal repro case project (OPTIONAL):

gui_crash_liveupdate.zip

Additional context (OPTIONAL):
https://forum.defold.com/t/replace-atlast-with-liveupdate-version/76540
@d954mas d954mas added the bug Something is not working as expected label Apr 11, 2024
@britzl britzl added engine Issues related to the Defold engine gui Issues related to gui components live update Issue related to the Live Update feature labels Apr 11, 2024
@d954mas
Copy link
Contributor Author

d954mas commented Apr 11, 2024

In this repro case i don't use liveupdate.

@AGulev AGulev removed the live update Issue related to the Live Update feature label Apr 11, 2024
@Jhonnyg Jhonnyg self-assigned this May 17, 2024
@Jhonnyg Jhonnyg mentioned this issue May 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Jhonnyg Jhonnyg

Labels
bug Something is not working as expected engine Issues related to the Defold engine gui Issues related to gui components
Projects
1.8.2
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use resource pointers all the way for GUI textures defold/defold
4 participants
@Jhonnyg @britzl @AGulev @d954mas