Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add retry logic to the BatchedExpressionEvaluator #2337

Open
elliette opened this issue Jan 10, 2024 · 1 comment
Open

Add retry logic to the BatchedExpressionEvaluator #2337

elliette opened this issue Jan 10, 2024 · 1 comment

Comments

@elliette
Copy link
Collaborator

Currently, if any of the expressions in the BatchedExpressionEvaluator fail, then all the expressions fail.

When this happens, we should re-try the expressions individually.

@annagrin
Copy link
Contributor

annagrin commented Jan 10, 2024

Retrying individually is too expensive unfortunately - the flutter widget inspector won't be responsive in this case (will take ~15 sec to show node's children on hover), and most likely all of them will fail if one does, as the failures we are currently seeing are a not an expected behavior and is probably due to a bug in how and why the evaluate() is called, or a missing evaluate() case support in dwds, or both:)

Normal failures (such as compilation errors) should be handled already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants