Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Wildcard Variables] Analyzer Implementation #55680

Open
9 of 24 tasks
Tracked by #55673
kallentu opened this issue May 9, 2024 · 1 comment
Open
9 of 24 tasks
Tracked by #55673

[Wildcard Variables] Analyzer Implementation #55680

kallentu opened this issue May 9, 2024 · 1 comment
Labels
area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. feature-wildcard-variables Implementation of the wildcard variables feature P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug

Comments

@kallentu
Copy link
Member

kallentu commented May 9, 2024

This meta issue tracks all the analyzer implementation work items. Referenced from: https://github.com/dart-lang/sdk/blob/main/pkg/analyzer/doc/process/new_language_feature.md

Work Items

  • AST enhancements (AstBuilder)
    • For both locals and parameters, distinguish between wildcard and regular declarations. Keep element for future use in areas like renaming.
  • Resolution of directives
  • Element model
  • Type system updates
  • Summary support
    • Make sure still works as intended.
  • Resolution
    • ResolutionVisitor (resolve types)
    • ScopeResolverVisitor (resolve simple identifiers by scope)
      • Don't put wildcard variables in scope.
    • ResolverVisitor (type-based resolution)
  • Constant evaluation
    • Verify with some tests that constants still work as expected with wildcards.
  • Index and search
  • Warnings (annotation-based, unused*, strict-mode-based, a few others)
  • ExitDetector
  • NodeLintRegistry
@kallentu kallentu added area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. area-meta Cross-cutting, high-level issues (for tracking many other implementation issues, ...). and removed area-meta Cross-cutting, high-level issues (for tracking many other implementation issues, ...). labels May 9, 2024
@srawlins srawlins added type-enhancement A request for a change that isn't a bug P2 A bug or feature request we're likely to work on labels May 10, 2024
@kallentu
Copy link
Member Author

@pq I updated what needs to be done in the analyzer with a short note from the kickoff. If it's easier to track with singular issues, we can do that too.

I suspect this work can start soon. I'm currently slowly adding language tests to the repo and I usually use those as a good indicator of what's working and what isn't.

@pq pq added the feature-wildcard-variables Implementation of the wildcard variables feature label May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. feature-wildcard-variables Implementation of the wildcard variables feature P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

No branches or pull requests

3 participants