What should OmittedTypeAnnotation.code produce?

[jakemac53]

Today, it ends up putting the OmittedTypeAnnotation directly into the code.

We could keep that, and possibly just change the toString() of OmittedTypeAnnotation, but that seems a bit weird.

In https://dart-review.googlesource.com/c/sdk/+/365960/1 I tried to change the code object to just the string <omitted>, but that broke various tests - it looks like we are actually putting in the inferred type eventually through some magic smarts, at least in some scenarios. But, I don't really understand the mechanisms at play here.

cc @johnniwinther

[johnniwinther]

In phase 1+2 augmentation libraries the omitted types are generated as OmittedType1, OmittedType2, etc and replaced with the inferred type in phase 3 and merged augmentation libraries. I think we assert or throw if the type isn't inferred.

[jakemac53]

Ok, so you do expect to get the actual OmittedTypeAnnotation back? I could just update the Code API docs to say that these are also valid.