Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CP] Cherry-Pick "[cfe] Ensure default values in synthesized function nodes" #55656

Closed
mkustermann opened this issue May 7, 2024 · 6 comments
Closed

[CP] Cherry-Pick "[cfe] Ensure default values in synthesized function nodes" #55656

mkustermann opened this issue May 7, 2024 · 6 comments
Assignees
@vsmenon @itsjustkevin @mit-mit @athomas
Labels
area-front-end Use area-front-end for front end / CFE / kernel format related issues. cherry-pick-approved Label for approved cherrypick request cherry-pick-review Issue that need cherry pick triage to approve merge-to-beta

Comments

@mkustermann
Copy link
Member

Commit(s) to merge

54031e2

Target

beta

Prepared changelist for beta/stable

https://dart-review.googlesource.com/c/sdk/+/365580

Issue Description

Without this fix some apps run into crashes of the dart2wasm compiler, see #55529

What is the fix

The fix is to ensure synthetic functions created by CFE have default values for parameters where needed.

Why cherry-pick

We don't want customers to run into dart2wasm crashes in next stable branch.

Risk

If we run all CI tests on cherry-pick requests then risk is low. /cc @johnniwinther @chloestefantsova wdyt?

Issue link(s)

#55529

Extra Info

No response
@mkustermann mkustermann added the cherry-pick-review Issue that need cherry pick triage to approve label May 7, 2024
@johnniwinther
Copy link
Member

LGTM

@vsmenon
Copy link
Member

vsmenon commented May 7, 2024

lgtm

@itsjustkevin itsjustkevin added cherry-pick-approved Label for approved cherrypick request merge-to-beta labels May 7, 2024
@itsjustkevin
Copy link
Contributor

@mkustermann go ahead and merge please.

copybara-service bot pushed a commit that referenced this issue May 8, 2024
@mkustermann
[beta] [cfe] Ensure default values in synthesized function nodes
19a6a7f 
Closes #55529

Cherry-pick: https://dart-review.googlesource.com/c/sdk/+/364325
Cherry-pick-request: #55656
Change-Id: If352b8f2f2d09deb2805d4279177fb16941af873
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/365580
Reviewed-by: Slava Egorov <vegorov@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
@devoncarew devoncarew added the area-front-end Use area-front-end for front end / CFE / kernel format related issues. label May 8, 2024
@mkustermann
Copy link
Member Author

@itsjustkevin The cherry-pick landed last week. That will ensure it will be included in the stable release for I/O, correct? If so, we can close this issue.

@itsjustkevin
Copy link
Contributor

We can close this issue @mkustermann. This cherry-pick missed the cutoff for the next release. If we create the cherry-pick again on top of the stable branch, we can get it in the first hotfix release.

CC @kevmoo

@mkustermann mkustermann mentioned this issue May 14, 2024
Open
@mkustermann
Copy link
Member Author

We can close this issue @mkustermann. This cherry-pick missed the cutoff for the next release. If we create the cherry-pick again on top of the stable branch, we can get it in the first hotfix release.

Filed a CP for stable here: #55714

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vsmenon vsmenon

@itsjustkevin itsjustkevin

@mit-mit mit-mit

@athomas athomas

Labels
area-front-end Use area-front-end for front end / CFE / kernel format related issues. cherry-pick-approved Label for approved cherrypick request cherry-pick-review Issue that need cherry pick triage to approve merge-to-beta
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@devoncarew @vsmenon @mkustermann @itsjustkevin @johnniwinther @mit-mit @athomas