[cronet_http] Apply relevant rules with the ProGuard #1204

AlexV525 · 2024-05-18T14:54:47Z

Resolves #1179

I’ve reviewed the contributor guide and applied the relevant portions to this PR.

Contribution guidelines:

See our contributor guide for general expectations for PRs.
Larger or significant changes should be discussed in an issue before creating a PR.
Contributions to our repos should follow the Dart style guide and use dart format.
Most changes should add an entry to the changelog and may need to rev the pubspec package version.
Changes to packages require corresponding tests.

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

AlexV525 · 2024-05-19T01:31:50Z

pkgs/cronet_http/CHANGELOG.md

pkgs/cronet_http/pubspec.yaml

brianquinlan · 2024-05-24T02:20:08Z

🔧 Apply relevant rules with the ProGuard

da88974

github-actions bot added the package:cronet_http label May 18, 2024

AlexV525 changed the title ~~🔧 Apply relevant rules with the ProGuard~~ [cronet_http] Apply relevant rules with the ProGuard May 18, 2024

AlexV525 added 2 commits May 18, 2024 23:05

Update CHANGELOG.md

1b857eb

Update pubspec.yaml

8643719

Codel1417 mentioned this pull request May 19, 2024

Cronet android does not work in release mode OpenTails/tail_app#149

Open

brianquinlan requested changes May 23, 2024

View reviewed changes

pkgs/cronet_http/CHANGELOG.md Outdated Show resolved Hide resolved

pkgs/cronet_http/pubspec.yaml Outdated Show resolved Hide resolved

Merge branch 'master' into fix/proguard-rules

36f588f

AlexV525 requested a review from brianquinlan May 24, 2024 01:52

brianquinlan approved these changes May 24, 2024

View reviewed changes

brianquinlan merged commit a2e241b into dart-lang:master May 24, 2024
29 of 30 checks passed

Provide feedback