Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Some ideas #19

Open
chrloew opened this issue Dec 16, 2020 · 3 comments
Open

[Feature] Some ideas #19

chrloew opened this issue Dec 16, 2020 · 3 comments

Comments

@chrloew
Copy link

chrloew commented Dec 16, 2020

Dear developers,
really like your project, thank you for it! The inter-platform availability is a real treat. Some ideas for improvement:

  • Don't think I have to say much about the ubiquitous echo
  • Ghosts should not be heard by alive players (this is a known bug I think, just mention it for sake of completeness w.r.t my experience using your prototype
  • Once the game has started, no further people not in the game should be able to join the auproximity-voice chat
  • The web interface should visualize who is talking (subjectively from the perspective of a player)
  • The "join"-button, which if I understood it correctly makes the bot join the game lobby, should not be available to anybody or be more transparent in what it does / if it has done so correctly. Otherwise it seems intransparent whether people clicking "join" break things. Following the way it is done in the game itself, there could be a host interface and a participant interface.
  • The web interface should notice when the bot connection is broken and inform the user about it

Thanks again!

@edqx
Copy link
Collaborator

edqx commented Dec 16, 2020

Firstly, this isn't a prototype, although it is an early version.

For the second one, I'm working on a rewrite for the library we use to join the Among Us game to record data.

And I'm afraid I don't follow the 5th point, do you mean that the join button should go away/be disabled once you have joined the game?

Rest of the points are great suggestions, thanks.

@chrloew
Copy link
Author

chrloew commented Dec 16, 2020

Ad 5): If I got it correctly, the "join" button serves the purpose of (1) making the bot join the game and (2) connect the person who set up the auproximity-lobby. Noone else really needs to press the "join" button. They open the shared link, a modal asks them for their nickname in-game and they are connected. It seems to me that having this button available to all users who then make the bot join over and over again (?) is at least unnecessary and possibly confusing, and could break things (thinking of how easily things break atm).
The suggestion means that making the bot join the game should be a functionality available only to the game host, for consistency reasons, with details such as hand-over to another person once the game-host leaves the among-us lobby to be figured out separately.

@edqx
Copy link
Collaborator

edqx commented Dec 18, 2020

This would require the host to join just so others can use proximity chat, which isn't really ideal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants