Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sheet can't paste image #1429

Open
Keeyuu opened this issue Mar 14, 2024 · 3 comments
Open

Sheet can't paste image #1429

Keeyuu opened this issue Mar 14, 2024 · 3 comments
Labels
Feature Request Something you want that isn't implemented Spreadsheet Related to the Spreadsheet app

Comments

@Keeyuu
Copy link

Keeyuu commented Mar 14, 2024

Description

I tried other formats like documents and markdown, and they worked just fine. It's only with spreadsheets that I'm having an issue. Here's what I'm doing: I copy an image to the clipboard using ctrl+c, then in the spreadsheet, I try to paste it using ctrl+v. But it doesn't just paste the image directly onto the sheet like it does in a document. And no window pops up to let me upload the image either.

Steps to reproduce

  1. I copy an image to the clipboard using ctrl+c
  2. then in the spreadsheet
  3. I try to paste it using ctrl+v. But it doesn't just paste the image directly onto the sheet like it does in a document. And no window pops up to let me upload the image either.

Relevant logs

no

Expected behavior

no

Which operating system are you using?

Linux/BSD/UNIX

What browsers are you seeing the problem on?

Microsoft Edge

Extensions

no

Version

5.7.0

@mathilde-cryptpad mathilde-cryptpad added Feature Request Something you want that isn't implemented Spreadsheet Related to the Spreadsheet app labels Mar 14, 2024
@Keeyuu
Copy link
Author

Keeyuu commented Mar 25, 2024

I would like to inquire about which part of the code need to be modified in order to implement this additional feature. I would like to manually implement it first.

@wginolas
Copy link
Contributor

Hello @Keeyuu, thanks for your interest in contributing to CryptPad!

This is a difficult one. CryptPad uses a modified version of OnlyOffice. The code that handles the clipboard is here: https://github.com/cryptpad/sdkjs/blob/cp7.3.3.60/cell/model/clipboard.js#L2804 . As you see the pasting of images is not implemented and disabled by us.

Pasted images have to be uploaded into CryptPad first and then inserted into OnlyOffice.

@Keeyuu
Copy link
Author

Keeyuu commented Mar 27, 2024

Hello @Keeyuu, thanks for your interest in contributing to CryptPad!

This is a difficult one. CryptPad uses a modified version of OnlyOffice. The code that handles the clipboard is here: https://github.com/cryptpad/sdkjs/blob/cp7.3.3.60/cell/model/clipboard.js#L2804 . As you see the pasting of images is not implemented and disabled by us.

Pasted images have to be uploaded into CryptPad first and then inserted into OnlyOffice.

Thanks for your patient guidance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request Something you want that isn't implemented Spreadsheet Related to the Spreadsheet app
Projects
None yet
Development

No branches or pull requests

3 participants