You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When you use FilePlayer (html5) each time the user click on play - autoplay attribute is added. And versa, clicking in pause - autoplay attribute is removed.
Expected Behavior
Autoplay attribute should not rely on 'playing' props.
It cause many issues with analytics tracking, when you have lazy video loading and disabled autoplay. User clicks on play - autoplay attribute is added.
The text was updated successfully, but these errors were encountered:
Current Behavior
When you use FilePlayer (html5) each time the user click on play - autoplay attribute is added. And versa, clicking in pause - autoplay attribute is removed.
Expected Behavior
Autoplay attribute should not rely on 'playing' props.
Steps to Reproduce
It even reproduces on official demo page
If I look at the code, I see in file https://github.com/cookpete/react-player/blob/master/src/players/FilePlayer.js line 359
autoPlay={playing || undefined}
, which does exactly what was described. However, this is not how autoplay should work by default.It cause many issues with analytics tracking, when you have lazy video loading and disabled autoplay. User clicks on play - autoplay attribute is added.
The text was updated successfully, but these errors were encountered: