Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jigsaw/module-info.java support? #101

Open
chengenzhao opened this issue Jan 20, 2021 · 4 comments
Open

jigsaw/module-info.java support? #101

chengenzhao opened this issue Jan 20, 2021 · 4 comments

Comments

@chengenzhao
Copy link

Hi,

It would be nice to have a modular info for this project
since we are using Java version 9+ to build the game
many dependencies we are using have been modularized except this one

Screen Shot 2021-01-20 at 8 31 24 PM

thanks

@XenoAmess
Copy link

XenoAmess commented Feb 9, 2021

For my own opinion, I HATE jigsaw.
But adding module-info.java seems no harm(to no-jigsaw users).

@tlf30
Copy link

tlf30 commented Oct 11, 2022

I second this, it would be great to get module support. If necessary I can help get a PR together, or help answer any questions you have on implementing it.

@tlf30
Copy link

tlf30 commented Jan 10, 2023

@code-disaster I am looking at putting together a PR.
I have hit a major blocking issue in making a simple migration using automation module names.
Shared package between steamworks4j and steamworks4j-server jars. This is an issue because JMS does not allow classes in the same package from two different modules. A solution would be to move everything in the steamworks4j-server jar into its own classpath, such as com.codedisaster.steamworks.server, but because of the use of package private (protected) access between the two jars, this is not possible. Perhaps the best solution would be to merge the two jars into a single jar.

Thoughts?

EDIT: Please see draft pr #124

@bowbahdoe
Copy link

Bump

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants