Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature]: Enahance parsing of postgres configuration booleans in webhooks #4252

Closed
mnencia opened this issue Apr 9, 2024 · 1 comment · Fixed by #4494
Closed

[Feature]: Enahance parsing of postgres configuration booleans in webhooks #4252

mnencia opened this issue Apr 9, 2024 · 1 comment · Fixed by #4494
Assignees
@leonardoce
Labels
enhancement 🪄 New feature or request
Milestone
1.24.0

Comments

@mnencia
Copy link
Member

mnencia commented Apr 9, 2024 •
edited

From the Postgres docs about the config file:

Boolean: Values can be written as on, off, true, false, yes, no, 1, 0 (all case-insensitive) or any unambiguous prefix of one of these.

In webhooks, we compare the archive_mode and wal_log_hints parameter values to "off".

That means that a user could set it to "0", "no", or even "OFF" and go ahead with a broken configuration.

Originally posted by @mnencia in #4218 (comment)
@mnencia mnencia mentioned this issue Apr 9, 2024
Merged
@mnencia mnencia added this to the 1.23.0 milestone Apr 9, 2024
@mnencia mnencia changed the title Enahance parsing of postgres booleans in webhooks [Feature]: Enahance parsing of postgres configuration booleans in webhooks Apr 9, 2024
@mnencia mnencia added the enhancement 🪄 New feature or request label Apr 15, 2024
@mnencia mnencia modified the milestones: 1.23.0, 1.24.0 Apr 22, 2024
@jsilvela jsilvela mentioned this issue May 9, 2024
Merged
@jsilvela
Copy link
Collaborator

jsilvela commented May 9, 2024

archive_mode is not a boolean but an enum, so this doesn't apply.
For hot_standby_feedback though, that's also a boolean.

leonardoce pushed a commit that referenced this issue May 28, 2024
@jsilvela @mnencia @gabriele-wolfox
chore: admit general PG booleans for configuration (#4494)
9a09548 
Allows any valid Postgres boolean for configuration in the webhooks.
Currently, only `off` and `on` are properly understood by the webhooks.

Closes #4252

Signed-off-by: Jaime Silvela <jaime.silvela@enterprisedb.com>
Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
Signed-off-by: Gabriele Quaresima <gabriele.quaresima@enterprisedb.com>
Co-authored-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
Co-authored-by: Gabriele Quaresima <gabriele.quaresima@enterprisedb.com>
cnpg-bot pushed a commit that referenced this issue May 28, 2024
@jsilvela
chore: admit general PG booleans for configuration (#4494)
e3297b3 
Allows any valid Postgres boolean for configuration in the webhooks.
Currently, only `off` and `on` are properly understood by the webhooks.

Closes #4252

Signed-off-by: Jaime Silvela <jaime.silvela@enterprisedb.com>
Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
Signed-off-by: Gabriele Quaresima <gabriele.quaresima@enterprisedb.com>
Co-authored-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
Co-authored-by: Gabriele Quaresima <gabriele.quaresima@enterprisedb.com>
(cherry picked from commit 9a09548)
cnpg-bot pushed a commit that referenced this issue May 28, 2024
@jsilvela
chore: admit general PG booleans for configuration (#4494)
6af85ea 
Allows any valid Postgres boolean for configuration in the webhooks.
Currently, only `off` and `on` are properly understood by the webhooks.

Closes #4252

Signed-off-by: Jaime Silvela <jaime.silvela@enterprisedb.com>
Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
Signed-off-by: Gabriele Quaresima <gabriele.quaresima@enterprisedb.com>
Co-authored-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
Co-authored-by: Gabriele Quaresima <gabriele.quaresima@enterprisedb.com>
(cherry picked from commit 9a09548)
cnpg-bot pushed a commit that referenced this issue May 28, 2024
@jsilvela
chore: admit general PG booleans for configuration (#4494)
adcc37e 
Allows any valid Postgres boolean for configuration in the webhooks.
Currently, only `off` and `on` are properly understood by the webhooks.

Closes #4252

Signed-off-by: Jaime Silvela <jaime.silvela@enterprisedb.com>
Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
Signed-off-by: Gabriele Quaresima <gabriele.quaresima@enterprisedb.com>
Co-authored-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
Co-authored-by: Gabriele Quaresima <gabriele.quaresima@enterprisedb.com>
(cherry picked from commit 9a09548)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leonardoce leonardoce

Labels
enhancement 🪄 New feature or request
Projects
CloudNativePG operator development
Status: Done
Milestone
1.24.0
Development

Successfully merging a pull request may close this issue.

chore: admit general PG booleans for configuration cloudnative-pg/cloudnative-pg
3 participants
@mnencia @jsilvela @leonardoce