Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleting an Experiment Run #64

Open
2 of 4 tasks
chovanecm opened this issue Jul 7, 2017 · 9 comments
Open
2 of 4 tasks

Deleting an Experiment Run #64

chovanecm opened this issue Jul 7, 2017 · 9 comments
Labels

Comments

@chovanecm
Copy link
Owner

chovanecm commented Jul 7, 2017

The user indicates he wants to delete a particular experiment run.

  1. The user selects the experiment to delete. (by opening its detail view).
  2. The system shows a delete option in the detail view. (left-bottom under the menu).
  3. The tells the system to delete the experiment. (clicking on a delete button in the left-bottom)
  4. The system verifies the intention to delete the experiment. (a confirmation dialog)
  5. The user confirms his choice.
  6. The system deletes the run. (invoking DELETE on /api/run/<id>, which also deletes corresponding metrics, fs.files, and all other related entries).
  7. The system closes the detail view.
  8. The system removes the run from the table.

Postconditions:

  1. The run is deleted.
  2. Related metrics are deleted.
  3. Related sources are deleted.
  4. Related artifacts are deleted.

Alternative scenarios

    • The user does not confirm the choice - the run won't be deleted. (Postconditions do not apply)
    • The run couldn't be deleted. The user is informed with an alert box.
@chovanecm chovanecm added this to the scipy2017 milestone Jul 7, 2017
@chovanecm chovanecm added the Epic label Jul 7, 2017
@chovanecm chovanecm removed this from the scipy2017 milestone Jul 9, 2017
chovanecm added a commit that referenced this issue Sep 17, 2017
BDD tests were added for educational purposes
#16 #64 #66
@chovanecm chovanecm changed the title Add a DELETE button to the experiment detail view Deleting an Experiment Run Oct 22, 2017
@timmeinhardt
Copy link

Is this still in progress?

@chovanecm
Copy link
Owner Author

chovanecm commented Nov 22, 2017

It's partially implemented - only the run itself and its metrics (if used) are deleted. Some garbage (like sources and artifacts) are not deleted, though.
It's in the development version:
pip install https://github.com/chovanecm/sacredboard/archive/develop.zip

When I will have time to finish it is currently unclear :-(

@timmeinhardt
Copy link

I just installed the develop version but there is still no button to delete a run. Maybe I am overlooking something.

@chovanecm
Copy link
Owner Author

Should be in the experiment detail view, I just checked it:
delete

@DennisSoemers
Copy link

I just also installed the develop version. The DELETE button does not show up if I view sacredboard in Firefox, but it does show up in Google Chrome @timmeinhardt

@timmeinhardt
Copy link

After reinstalling it a second time the button showed up as well. Maybe Chrome was still using a cached version or something. Thank you. Works quite well so far!

@DennisSoemers
Copy link

Ah yes. Hitting F5 to refresh made it also show up for me in Firefox, so probably indeed due to caching.

@timmeinhardt
Copy link

Why is this closed? Related artefacts and sources are not yet deleted.

@chovanecm
Copy link
Owner Author

chovanecm commented Jan 17, 2018

My fault, I wanted to split it into several issues so that I can close each of them but now I realize I can keep this as a "parent" task.
But I think I will put it into "icebox" then because I don't currently plan to work on it.

@chovanecm chovanecm reopened this Jan 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants