You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Our xdoc's links need to be relative so we don't break out of version documentation. I pasted the link to one example in the first post and showed the text of the link. It is not relative, and will take user out of version documentation.
It is the same as #14876 except these links are connected to our templates.
Edit: Our doxia macros have no connection here. I thought there was. We should still look into our javadoc and xdoc synchronizer test and maybe somehow ensure xdoc's links are always relative.
As seen in https://checkstyle.sourceforge.io/version/10.15.0/checks/coding/declarationorder.html#DeclarationOrder
Link generated is https://checkstyle.org/styleguides/sun-code-conventions-19990420/CodeConventions.doc2.html#a1852 and breaks out of the version documentation. Link's generated source from the macro is at
checkstyle/src/xdocs/checks/coding/declarationorder.xml
Line 15 in 45cbedf
We should be kept in the specific version as much as possible.
This link comes from
checkstyle/src/main/java/com/puppycrawl/tools/checkstyle/checks/coding/DeclarationOrderCheck.java
Line 38 in 45cbedf
Javadoc should stay absolute, but conversion to xdoc should make it relative. It looks like ~12 pages do this in total.
The text was updated successfully, but these errors were encountered: