Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CAL-3746] Top right section overflows in Event page #14682

Closed
Afrin127329 opened this issue Apr 21, 2024 · 3 comments · Fixed by #15109
Closed

[CAL-3746] Top right section overflows in Event page #14682

Afrin127329 opened this issue Apr 21, 2024 · 3 comments · Fixed by #15109
Labels
🧹 Improvements Improvements to existing features. Mostly UX/UI Low priority Created by Linear-GitHub Sync ⚡ Quick Wins A collection of quick wins/quick fixes that are less than 30 minutes of work ui area: UI, frontend, button, form, input
Milestone

Comments

@Afrin127329
Copy link
Contributor

Afrin127329 commented Apr 21, 2024

Issue Summary

Not sure if this is a browser issue or not. But it kinda looks ugly when top right section is overflowing and it's blocking the stuff below it. Here are the examples.

cal2
cal3

Steps to Reproduce

  1. login
  2. Open any event link

Expected Results

  • The main section could use some more space at the top.

Technical details

  • Browser Mozilla, Chrome

CAL-3746

Copy link

dosubot bot commented Apr 21, 2024

It looks like the overflow issue on the Event page you're experiencing could be due to the CSS classes controlling overflow behavior, specifically overflow-y-auto and overflow-hidden. These classes might be causing content to overflow or be hidden inappropriately, especially when combined with layout styles like flex and whitespace-nowrap.

To address this, you might want to consider the following adjustments:

  1. Remove overflow-y-auto from the eventClasses definition: This class allows vertical scrolling within the event elements, which might not be necessary and could contribute to layout issues.

  2. Review and potentially adjust the use of overflow-hidden and whitespace-nowrap: If the content is overflowing and causing layout issues, consider allowing the text to wrap or providing more space for the content to expand.

Here's a code snippet suggestion for your Event.tsx component:

const eventClasses = cva(
  "group flex h-full w-full rounded-[6px] px-[6px] text-xs font-semibold leading-5 opacity-80",
  {
    // Your variants here
  }
);

<div
  className="flex w-full gap-2 overflow-visible text-left leading-4">
  <span>{event.title}</span>
  // Additional content here
</div>

In this adjustment, I've suggested removing overflow-y-auto and changing overflow-hidden and whitespace-nowrap to overflow-visible in the inner div to allow content to expand as needed without being cut off. This should help address the overflow issue without blocking content below the event section on the page.

Details

Sources


About Dosu
This response is meant to be useful and save you time. It is not meant to be a precise solution, but rather a starting point for your own research.

Help me be more useful! Please leave a 👍 if this is helpful and 👎 if it is irrelevant.

To continue the conversation, mention @dosu.

@dosubot dosubot bot added ui area: UI, frontend, button, form, input 🧹 Improvements Improvements to existing features. Mostly UX/UI labels Apr 21, 2024
@heykvr
Copy link

heykvr commented Apr 23, 2024

I would like to work on this issue @dosu

@PeerRich PeerRich added the ⚡ Quick Wins A collection of quick wins/quick fixes that are less than 30 minutes of work label May 16, 2024
@PeerRich
Copy link
Member

you are right, we need to have more padding at the top for smaller devices in height. adding to roadmap for this month

@PeerRich PeerRich added this to the v4.2 milestone May 16, 2024
@PeerRich PeerRich changed the title Top right section overflows in Event page [CAL-3746] Top right section overflows in Event page May 16, 2024
@PeerRich PeerRich added the Low priority Created by Linear-GitHub Sync label May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧹 Improvements Improvements to existing features. Mostly UX/UI Low priority Created by Linear-GitHub Sync ⚡ Quick Wins A collection of quick wins/quick fixes that are less than 30 minutes of work ui area: UI, frontend, button, form, input
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants