init_gizmo_group silently ignores missing RenderApp if in wrong order

[RubenArtmann]

Bevy version

0.13.2

What you did

I had a plugin that loaded before DefaultPlugins.
Everything worked. Even the Gizmos (the default group is loaded by something else later).
I tried moving to my own GizmoConfigGroup.
I did everything like the 3d gizmo demo, but they would not render.
After an embarrassing amount of time i figured out, that i had to move the plugin initialization down one line.

What went wrong

it seems you have moved the initialization of the gizmo renderer into GizmoPlugin::build now, which is better, because the plugin is probably loaded using DefaultPlugins and therefore in the correct order, but someone like me could still mess it up.
bevy_gizmos/src/lib.rs GizmoPlugin::build

let Some(render_app) = app.get_sub_app_mut(RenderApp) else {
    return;
};

for `release-0.13.2`

bevy_gizmos/src/lib.rs App::init_gizmo_group

let Ok(render_app) = self.get_sub_app_mut(RenderApp) else {
    // this should probably panic!
    return self;
};

// this is the expected (and needed if you do not have your own renderer) behaviour
render_app.add_systems(ExtractSchedule, extract_gizmo_data::<T>);

What should happen

The app should panic! (or at least warn!) if it can not find the renderer.

Proposed Solution

you seem to have refactored it in the main branch, but you still dont do it like you do for the other plugins right under it

        #[cfg(feature = "bevy_sprite")]
        if app.is_plugin_added::<bevy_sprite::SpritePlugin>() {
            app.add_plugins(pipeline_2d::LineGizmo2dPlugin);
        } else {
            bevy_utils::tracing::warn!("bevy_sprite feature is enabled but bevy_sprite::SpritePlugin was not detected. Are you sure you loaded GizmoPlugin after SpritePlugin?");
        }

for `release-0.13.2`

The easiest solution would be to just panic if bevy was build with the renderer and it was not found,
but that would mean you could not use this function if you use a different Renderer and you build bevy with its own.

The better solution would probably be to just split the function into init_gizmo_group_without_renderer and init_gizmo_group_and_renderer (so old users get a compilation error and need to decide which version they need, or just use the old version and let people with a custom renderer deal with it, since it would panic for them).

this also affects insert_gizmo_group

[alice-i-cecile]

Another casualty of #1255.