{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":234798675,"defaultBranch":"main","name":"bevy","ownerLogin":"bevyengine","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2020-01-18T21:13:55.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/60047606?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1716503700.0","currentOid":""},"activityList":{"items":[{"before":"ddb72fb0eeeded9578fe67f727338047614757f9","after":null,"ref":"refs/heads/gh-readonly-queue/main/pr-13366-ec01c2dc4562adb979cf5497a48b53efa8250901","pushedAt":"2024-05-23T22:35:00.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"}},{"before":null,"after":"ddb72fb0eeeded9578fe67f727338047614757f9","ref":"refs/heads/gh-readonly-queue/main/pr-13366-ec01c2dc4562adb979cf5497a48b53efa8250901","pushedAt":"2024-05-23T22:33:56.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"},"commit":{"message":"fix: upgrade to winit v0.30 (#13366)\n\n# Objective\n\n- Upgrade winit to v0.30\n- Fixes https://github.com/bevyengine/bevy/issues/13331\n\n## Solution\n\nThis is a rewrite/adaptation of the new trait system described and\nimplemented in `winit` v0.30.\n\n## Migration Guide\n\nThe custom UserEvent is now renamed as WakeUp, used to wake up the loop\nif anything happens outside the app (a new\n[custom_user_event](https://github.com/bevyengine/bevy/pull/13366/files#diff-2de8c0a8d3028d0059a3d80ae31b2bbc1cde2595ce2d317ea378fe3e0cf6ef2d)\nshows this behavior.\n\nThe internal `UpdateState` has been removed and replaced internally by\nthe AppLifecycle. When changed, the AppLifecycle is sent as an event.\n\nThe `UpdateMode` now accepts only two values: `Continuous` and\n`Reactive`, but the latter exposes 3 new properties to enable reactive\nto device, user or window events. The previous `UpdateMode::Reactive` is\nnow equivalent to `UpdateMode::reactive()`, while\n`UpdateMode::ReactiveLowPower` to `UpdateMode::reactive_low_power()`.\n\nThe `ApplicationLifecycle` has been renamed as `AppLifecycle`, and now\ncontains the possible values of the application state inside the event\nloop:\n* `Idle`: the loop has not started yet\n* `Running` (previously called `Started`): the loop is running\n* `WillSuspend`: the loop is going to be suspended\n* `Suspended`: the loop is suspended\n* `WillResume`: the loop is going to be resumed\n\nNote: the `Resumed` state has been removed since the resumed app is just\nrunning.\n\nFinally, now that `winit` enables this, it extends the `WinitPlugin` to\nsupport custom events.\n\n## Test platforms\n\n- [x] Windows\n- [x] MacOs\n- [x] Linux (x11)\n- [x] Linux (Wayland)\n- [x] Android\n- [x] iOS\n- [x] WASM/WebGPU\n- [x] WASM/WebGL2\n\n---------\n\nCo-authored-by: François ","shortMessageHtmlLink":"fix: upgrade to winit v0.30 (#13366)"}},{"before":"ec01c2dc4562adb979cf5497a48b53efa8250901","after":null,"ref":"refs/heads/gh-readonly-queue/main/pr-13482-da1e6e63ff179eb884ba0023369161df8ba83563","pushedAt":"2024-05-23T16:28:03.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"}},{"before":"da1e6e63ff179eb884ba0023369161df8ba83563","after":"ec01c2dc4562adb979cf5497a48b53efa8250901","ref":"refs/heads/main","pushedAt":"2024-05-23T16:28:02.000Z","pushType":"merge_queue_merge","commitsCount":1,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"},"commit":{"message":"New circular primitives: `Arc2d`, `CircularSector`, `CircularSegment` (#13482)\n\n# Objective\n\nAdopted #11748\n\n## Solution\n\nI've rebased on main to fix the merge conflicts. ~~Not quite ready to\nmerge yet~~\n\n* Clippy is happy and the tests are passing, but...\n* ~~The new shapes in `examples/2d/2d_shapes.rs` don't look right at\nall~~ Never mind, looks like radians and degrees just got mixed up at\nsome point?\n* I have updated one doc comment based on a review in the original PR.\n\n---------\n\nCo-authored-by: Alexis \"spectria\" Horizon \nCo-authored-by: Alexis \"spectria\" Horizon <118812919+spectria-limina@users.noreply.github.com>\nCo-authored-by: Joona Aalto \nCo-authored-by: Alice Cecile \nCo-authored-by: Ben Harper ","shortMessageHtmlLink":"New circular primitives: Arc2d, CircularSector, CircularSegment (…"}},{"before":null,"after":"ec01c2dc4562adb979cf5497a48b53efa8250901","ref":"refs/heads/gh-readonly-queue/main/pr-13482-da1e6e63ff179eb884ba0023369161df8ba83563","pushedAt":"2024-05-23T16:13:01.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"},"commit":{"message":"New circular primitives: `Arc2d`, `CircularSector`, `CircularSegment` (#13482)\n\n# Objective\n\nAdopted #11748\n\n## Solution\n\nI've rebased on main to fix the merge conflicts. ~~Not quite ready to\nmerge yet~~\n\n* Clippy is happy and the tests are passing, but...\n* ~~The new shapes in `examples/2d/2d_shapes.rs` don't look right at\nall~~ Never mind, looks like radians and degrees just got mixed up at\nsome point?\n* I have updated one doc comment based on a review in the original PR.\n\n---------\n\nCo-authored-by: Alexis \"spectria\" Horizon \nCo-authored-by: Alexis \"spectria\" Horizon <118812919+spectria-limina@users.noreply.github.com>\nCo-authored-by: Joona Aalto \nCo-authored-by: Alice Cecile \nCo-authored-by: Ben Harper ","shortMessageHtmlLink":"New circular primitives: Arc2d, CircularSector, CircularSegment (…"}},{"before":"da1e6e63ff179eb884ba0023369161df8ba83563","after":null,"ref":"refs/heads/gh-readonly-queue/main/pr-13483-bd5148e0f5eb322c86c8a06a97c50d40385ecdd0","pushedAt":"2024-05-23T15:36:24.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"}},{"before":"bd5148e0f5eb322c86c8a06a97c50d40385ecdd0","after":"da1e6e63ff179eb884ba0023369161df8ba83563","ref":"refs/heads/main","pushedAt":"2024-05-23T15:36:24.000Z","pushType":"merge_queue_merge","commitsCount":1,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"},"commit":{"message":"Mention of Vec normalization for Dir::new (#13483)\n\n# Objective\n\n- Fixes #13429 .\n\n## Solution\n\n- Improved docs for methods `new`, `new_and_length` of `Dir2`, `Dir3`,\n`Dir3A`.","shortMessageHtmlLink":"Mention of Vec normalization for Dir::new (#13483)"}},{"before":null,"after":"da1e6e63ff179eb884ba0023369161df8ba83563","ref":"refs/heads/gh-readonly-queue/main/pr-13483-bd5148e0f5eb322c86c8a06a97c50d40385ecdd0","pushedAt":"2024-05-23T15:20:37.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"},"commit":{"message":"Mention of Vec normalization for Dir::new (#13483)\n\n# Objective\n\n- Fixes #13429 .\n\n## Solution\n\n- Improved docs for methods `new`, `new_and_length` of `Dir2`, `Dir3`,\n`Dir3A`.","shortMessageHtmlLink":"Mention of Vec normalization for Dir::new (#13483)"}},{"before":"bd5148e0f5eb322c86c8a06a97c50d40385ecdd0","after":null,"ref":"refs/heads/gh-readonly-queue/main/pr-13467-1d950e619575d45434072c6789936ddd5b866b69","pushedAt":"2024-05-23T15:18:52.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"}},{"before":"1d950e619575d45434072c6789936ddd5b866b69","after":"bd5148e0f5eb322c86c8a06a97c50d40385ecdd0","ref":"refs/heads/main","pushedAt":"2024-05-23T15:18:51.000Z","pushType":"merge_queue_merge","commitsCount":1,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"},"commit":{"message":"Add triangle_math tests and fix Triangle3d::bounding_sphere bug (#13467)\n\n# Objective\n\nAdopted #12659.\n\nResolved the merge conflicts on #12659;\n\n* I merged the `triangle_tests` added by this PR and by #13020.\n* I moved the [commented out\ncode](https://github.com/bevyengine/bevy/pull/12659#discussion_r1536640427)\nfrom the original PR into a separate test with `#[should_panic]`.\n\n---------\n\nCo-authored-by: Vitor Falcao \nCo-authored-by: Ben Harper ","shortMessageHtmlLink":"Add triangle_math tests and fix Triangle3d::bounding_sphere bug (#13467)"}},{"before":null,"after":"bd5148e0f5eb322c86c8a06a97c50d40385ecdd0","ref":"refs/heads/gh-readonly-queue/main/pr-13467-1d950e619575d45434072c6789936ddd5b866b69","pushedAt":"2024-05-23T15:03:16.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"},"commit":{"message":"Add triangle_math tests and fix Triangle3d::bounding_sphere bug (#13467)\n\n# Objective\n\nAdopted #12659.\n\nResolved the merge conflicts on #12659;\n\n* I merged the `triangle_tests` added by this PR and by #13020.\n* I moved the [commented out\ncode](https://github.com/bevyengine/bevy/pull/12659#discussion_r1536640427)\nfrom the original PR into a separate test with `#[should_panic]`.\n\n---------\n\nCo-authored-by: Vitor Falcao \nCo-authored-by: Ben Harper ","shortMessageHtmlLink":"Add triangle_math tests and fix Triangle3d::bounding_sphere bug (#13467)"}},{"before":"1d950e619575d45434072c6789936ddd5b866b69","after":null,"ref":"refs/heads/gh-readonly-queue/main/pr-13051-4dbfdcf1928a7017dde9af20ac8c81f693302bf1","pushedAt":"2024-05-23T13:44:22.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"}},{"before":"4dbfdcf1928a7017dde9af20ac8c81f693302bf1","after":"1d950e619575d45434072c6789936ddd5b866b69","ref":"refs/heads/main","pushedAt":"2024-05-23T13:44:22.000Z","pushType":"merge_queue_merge","commitsCount":1,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"},"commit":{"message":"Allow `AssetServer::load` to acquire a guard item. (#13051)\n\n# Objective\n\nSupercedes #12881 . Added a simple implementation that allows the user\nto react to multiple asset loads both synchronously and asynchronously.\n\n## Solution\n\nAdded `load_acquire`, that holds an item and drops it when loading is\nfinished or failed.\n\nWhen used synchronously \n\nHold an `Arc<()>`, check for `Arc::strong_count() == 1` when all loading\ncompleted.\n\nWhen used asynchronously \n\nHold a `SemaphoreGuard`, await on `acquire_all` for completion.\n\nThis implementation has more freedom than the original in my opinion.\n\n---------\n\nCo-authored-by: Alice Cecile \nCo-authored-by: Zachary Harrold ","shortMessageHtmlLink":"Allow AssetServer::load to acquire a guard item. (#13051)"}},{"before":null,"after":"1d950e619575d45434072c6789936ddd5b866b69","ref":"refs/heads/gh-readonly-queue/main/pr-13051-4dbfdcf1928a7017dde9af20ac8c81f693302bf1","pushedAt":"2024-05-23T13:28:45.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"},"commit":{"message":"Allow `AssetServer::load` to acquire a guard item. (#13051)\n\n# Objective\n\nSupercedes #12881 . Added a simple implementation that allows the user\nto react to multiple asset loads both synchronously and asynchronously.\n\n## Solution\n\nAdded `load_acquire`, that holds an item and drops it when loading is\nfinished or failed.\n\nWhen used synchronously \n\nHold an `Arc<()>`, check for `Arc::strong_count() == 1` when all loading\ncompleted.\n\nWhen used asynchronously \n\nHold a `SemaphoreGuard`, await on `acquire_all` for completion.\n\nThis implementation has more freedom than the original in my opinion.\n\n---------\n\nCo-authored-by: Alice Cecile \nCo-authored-by: Zachary Harrold ","shortMessageHtmlLink":"Allow AssetServer::load to acquire a guard item. (#13051)"}},{"before":"4dbfdcf1928a7017dde9af20ac8c81f693302bf1","after":null,"ref":"refs/heads/gh-readonly-queue/main/pr-13480-efcb6d6c11431e8184465794bd422f3b2f21e639","pushedAt":"2024-05-23T00:45:51.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"}},{"before":"efcb6d6c11431e8184465794bd422f3b2f21e639","after":"4dbfdcf1928a7017dde9af20ac8c81f693302bf1","ref":"refs/heads/main","pushedAt":"2024-05-23T00:45:50.000Z","pushType":"merge_queue_merge","commitsCount":1,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"},"commit":{"message":"Fix lighting example following emissive material changes in #13350 (#13480)\n\n# Objective\n\nAfter the emissive material changes in #13350, the red and green point\nlights in the `lighting` example turned white.\n\n## Solution\n\nThis PR gives the point lights the `emissive_exposure_weight` property\nin order for them to appear with correct color again.\n\n## Testing\n\nThe `lighting` example before this fix:\n\n\n![image](https://github.com/bevyengine/bevy/assets/143610747/be31d422-f616-4651-ab63-18ddfdba3773)\n\nAfter this fix (looks the same as before #13350):\n\n\n![image](https://github.com/bevyengine/bevy/assets/143610747/e5b5eab3-0588-4f30-bf74-2b52db7345ad)","shortMessageHtmlLink":"Fix lighting example following emissive material changes in #13350 (#…"}},{"before":null,"after":"4dbfdcf1928a7017dde9af20ac8c81f693302bf1","ref":"refs/heads/gh-readonly-queue/main/pr-13480-efcb6d6c11431e8184465794bd422f3b2f21e639","pushedAt":"2024-05-23T00:30:46.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"},"commit":{"message":"Fix lighting example following emissive material changes in #13350 (#13480)\n\n# Objective\n\nAfter the emissive material changes in #13350, the red and green point\nlights in the `lighting` example turned white.\n\n## Solution\n\nThis PR gives the point lights the `emissive_exposure_weight` property\nin order for them to appear with correct color again.\n\n## Testing\n\nThe `lighting` example before this fix:\n\n\n![image](https://github.com/bevyengine/bevy/assets/143610747/be31d422-f616-4651-ab63-18ddfdba3773)\n\nAfter this fix (looks the same as before #13350):\n\n\n![image](https://github.com/bevyengine/bevy/assets/143610747/e5b5eab3-0588-4f30-bf74-2b52db7345ad)","shortMessageHtmlLink":"Fix lighting example following emissive material changes in #13350 (#…"}},{"before":"efcb6d6c11431e8184465794bd422f3b2f21e639","after":null,"ref":"refs/heads/gh-readonly-queue/main/pr-13465-faf003fc9dd4c61380cc07b8868c3803a2aea048","pushedAt":"2024-05-22T23:51:17.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"}},{"before":"faf003fc9dd4c61380cc07b8868c3803a2aea048","after":"efcb6d6c11431e8184465794bd422f3b2f21e639","ref":"refs/heads/main","pushedAt":"2024-05-22T23:51:16.000Z","pushType":"merge_queue_merge","commitsCount":1,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"},"commit":{"message":"Make LoadContext use the builder pattern for loading dependent assets (#13465)\n\n# Objective\n- Fixes #13445.\n\n## Solution\n- Removes all `load_` methods from `LoadContext`.\n- Introduces `fn loader()` which returns a builder.\n\n## Testing\n- I've tested with `cargo test --package=bevy_asset` and run the two\nrelevant examples (`asset_processing` & `asset_decompression`).\n\n---\n\n## Changelog\n- Replaced all `load_` methods on `LoadContext` with the new `loader()`\npattern.\n\n## Migration Guide\n- Several LoadContext method calls will need to be updated:\n- `load_context.load_with_settings(path, settings)` =>\n`load_context.loader().with_settings(settings).load(path)`\n- `load_context.load_untyped(path)` =>\n`load_context.loader().untyped().load(path)`\n- `load_context.load_direct(path)` =>\n`load_context.loader().direct().load(path)`\n- `load_context.load_direct_untyped(path)` =>\n`load_context.loader().direct().untyped().load(path)`\n- `load_context.load_direct_with_settings(path, settings)` =>\n`load_context.loader().with_settings(settings).direct().load(path)`\n- `load_context.load_direct_with_reader(reader, path)` =>\n`load_context.loader().direct().with_reader(reader).load(path)`\n- `load_context.load_direct_with_reader_and_settings(reader, path,\nsettings)` =>\n`load_context.loader().with_settings(settings).direct().with_reader(reader).load(path)`\n- `load_context.load_direct_untyped_with_reader(reader, path)` =>\n`load_context.loader().direct().with_reader(reader).untyped().load(path)`\n\n---\n\nCC @alice-i-cecile / @bushrat011899 \n\nExamples:\n```rust\nload_context.loader()\n .with_asset_type::()\n .with_asset_type_id(TypeId::of::())\n .with_settings(|mut settings| { settings.key = value; })\n // Then, for a Handle:\n .load::()\n // Or, for a Handle:\n .untyped()\n .load()\n // Or, to load an `A` directly:\n .direct()\n .load::()\n .await\n // Or, to load an `ErasedLoadedAsset` directly:\n .direct()\n .untyped()\n .load()\n .await\n```","shortMessageHtmlLink":"Make LoadContext use the builder pattern for loading dependent assets (…"}},{"before":null,"after":"efcb6d6c11431e8184465794bd422f3b2f21e639","ref":"refs/heads/gh-readonly-queue/main/pr-13465-faf003fc9dd4c61380cc07b8868c3803a2aea048","pushedAt":"2024-05-22T23:35:57.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"},"commit":{"message":"Make LoadContext use the builder pattern for loading dependent assets (#13465)\n\n# Objective\n- Fixes #13445.\n\n## Solution\n- Removes all `load_` methods from `LoadContext`.\n- Introduces `fn loader()` which returns a builder.\n\n## Testing\n- I've tested with `cargo test --package=bevy_asset` and run the two\nrelevant examples (`asset_processing` & `asset_decompression`).\n\n---\n\n## Changelog\n- Replaced all `load_` methods on `LoadContext` with the new `loader()`\npattern.\n\n## Migration Guide\n- Several LoadContext method calls will need to be updated:\n- `load_context.load_with_settings(path, settings)` =>\n`load_context.loader().with_settings(settings).load(path)`\n- `load_context.load_untyped(path)` =>\n`load_context.loader().untyped().load(path)`\n- `load_context.load_direct(path)` =>\n`load_context.loader().direct().load(path)`\n- `load_context.load_direct_untyped(path)` =>\n`load_context.loader().direct().untyped().load(path)`\n- `load_context.load_direct_with_settings(path, settings)` =>\n`load_context.loader().with_settings(settings).direct().load(path)`\n- `load_context.load_direct_with_reader(reader, path)` =>\n`load_context.loader().direct().with_reader(reader).load(path)`\n- `load_context.load_direct_with_reader_and_settings(reader, path,\nsettings)` =>\n`load_context.loader().with_settings(settings).direct().with_reader(reader).load(path)`\n- `load_context.load_direct_untyped_with_reader(reader, path)` =>\n`load_context.loader().direct().with_reader(reader).untyped().load(path)`\n\n---\n\nCC @alice-i-cecile / @bushrat011899 \n\nExamples:\n```rust\nload_context.loader()\n .with_asset_type::()\n .with_asset_type_id(TypeId::of::())\n .with_settings(|mut settings| { settings.key = value; })\n // Then, for a Handle:\n .load::()\n // Or, for a Handle:\n .untyped()\n .load()\n // Or, to load an `A` directly:\n .direct()\n .load::()\n .await\n // Or, to load an `ErasedLoadedAsset` directly:\n .direct()\n .untyped()\n .load()\n .await\n```","shortMessageHtmlLink":"Make LoadContext use the builder pattern for loading dependent assets (…"}},{"before":"faf003fc9dd4c61380cc07b8868c3803a2aea048","after":null,"ref":"refs/heads/gh-readonly-queue/main/pr-13424-c4cedb12c895ef0c1f847b891e817e838a0a365b","pushedAt":"2024-05-22T21:34:30.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"}},{"before":"c4cedb12c895ef0c1f847b891e817e838a0a365b","after":"faf003fc9dd4c61380cc07b8868c3803a2aea048","ref":"refs/heads/main","pushedAt":"2024-05-22T21:34:29.000Z","pushType":"merge_queue_merge","commitsCount":1,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"},"commit":{"message":"bevy_reflect: `enum_utility` cleanup (#13424)\n\n# Objective\n\nThe `enum_utility` module contains the `get_variant_constructors`\nfunction, which is used to generate token streams for constructing\nenums. It's used for the `FromReflect::from_reflect` implementation and\nthe `Reflect::try_apply` implementation.\n\nDue to the complexity of enums, this function is understandably a little\nmessy and difficult to extend.\n\n## Solution\n\nClean up the `enum_utility` module.\n\nNow \"clean\" is a bit subjective. I believe my solution is \"cleaner\" in\nthat the logic to generate the tokens are strictly coupled with the\nintended usage. Because of this, `try_apply` is also no longer strictly\ncoupled with `from_reflect`.\n\nThis makes it easier to extend with new functionality, which is\nsomething I'm doing in a future unrelated PR that I have based off this\none.\n\n## Testing\n\nThere shouldn't be any testing required other than ensuring that the\nproject still builds and that CI passes.","shortMessageHtmlLink":"bevy_reflect: enum_utility cleanup (#13424)"}},{"before":null,"after":"faf003fc9dd4c61380cc07b8868c3803a2aea048","ref":"refs/heads/gh-readonly-queue/main/pr-13424-c4cedb12c895ef0c1f847b891e817e838a0a365b","pushedAt":"2024-05-22T21:19:14.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"},"commit":{"message":"bevy_reflect: `enum_utility` cleanup (#13424)\n\n# Objective\n\nThe `enum_utility` module contains the `get_variant_constructors`\nfunction, which is used to generate token streams for constructing\nenums. It's used for the `FromReflect::from_reflect` implementation and\nthe `Reflect::try_apply` implementation.\n\nDue to the complexity of enums, this function is understandably a little\nmessy and difficult to extend.\n\n## Solution\n\nClean up the `enum_utility` module.\n\nNow \"clean\" is a bit subjective. I believe my solution is \"cleaner\" in\nthat the logic to generate the tokens are strictly coupled with the\nintended usage. Because of this, `try_apply` is also no longer strictly\ncoupled with `from_reflect`.\n\nThis makes it easier to extend with new functionality, which is\nsomething I'm doing in a future unrelated PR that I have based off this\none.\n\n## Testing\n\nThere shouldn't be any testing required other than ensuring that the\nproject still builds and that CI passes.","shortMessageHtmlLink":"bevy_reflect: enum_utility cleanup (#13424)"}},{"before":"c4cedb12c895ef0c1f847b891e817e838a0a365b","after":null,"ref":"refs/heads/gh-readonly-queue/main/pr-13476-dda7a744cfa693ce309217b77eefe211fc253955","pushedAt":"2024-05-22T19:12:52.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"}},{"before":"dda7a744cfa693ce309217b77eefe211fc253955","after":"c4cedb12c895ef0c1f847b891e817e838a0a365b","ref":"refs/heads/main","pushedAt":"2024-05-22T19:12:51.000Z","pushType":"merge_queue_merge","commitsCount":1,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"},"commit":{"message":"simple Debug impls for query iterators (#13476)\n\n# Objective\n\nThe current query iterators cannot be used in positions with a `Debug`\nbound.\nF.e. when they are packaged in `Result` in the error position, `expect`\ncannot be called on them.\nRequired for `QueryManyIter::entities_all_unique` in #13477.\n\n## Solution\n\nAdd simple `Debug` impls that print the query iterator names.\n\n## Changelog\n\n`QueryIter`, `QueryManyIter`, `QueryCombinationIter`, and\n`QuerySortedIter` now implement `Debug`.","shortMessageHtmlLink":"simple Debug impls for query iterators (#13476)"}},{"before":null,"after":"c4cedb12c895ef0c1f847b891e817e838a0a365b","ref":"refs/heads/gh-readonly-queue/main/pr-13476-dda7a744cfa693ce309217b77eefe211fc253955","pushedAt":"2024-05-22T18:56:24.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"},"commit":{"message":"simple Debug impls for query iterators (#13476)\n\n# Objective\n\nThe current query iterators cannot be used in positions with a `Debug`\nbound.\nF.e. when they are packaged in `Result` in the error position, `expect`\ncannot be called on them.\nRequired for `QueryManyIter::entities_all_unique` in #13477.\n\n## Solution\n\nAdd simple `Debug` impls that print the query iterator names.\n\n## Changelog\n\n`QueryIter`, `QueryManyIter`, `QueryCombinationIter`, and\n`QuerySortedIter` now implement `Debug`.","shortMessageHtmlLink":"simple Debug impls for query iterators (#13476)"}},{"before":"dda7a744cfa693ce309217b77eefe211fc253955","after":null,"ref":"refs/heads/gh-readonly-queue/main/pr-13475-1ec5cdf3f2aac4d40cb641aa438531264cf4a0fe","pushedAt":"2024-05-22T18:43:34.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"}},{"before":"1ec5cdf3f2aac4d40cb641aa438531264cf4a0fe","after":"dda7a744cfa693ce309217b77eefe211fc253955","ref":"refs/heads/main","pushedAt":"2024-05-22T18:43:33.000Z","pushType":"merge_queue_merge","commitsCount":1,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"},"commit":{"message":"Further improve docs for component hooks (#13475)\n\n# Objective\n\nWhile reviewing the other open hooks-related PRs, I found that the docs\non the `ComponentHooks` struct itself didn't give enough information\nabout how and why the feature could be used.\n\n## Solution\n\n1. Clean up the docs to add additional context.\n2. Add a doc test demonstrating simple usage.\n\n## Testing\n\nThe doc test passes locally.\n\n---------\n\nCo-authored-by: Alice Cecile ","shortMessageHtmlLink":"Further improve docs for component hooks (#13475)"}},{"before":"b572b48bc55e4c72de7c08d470c9864f0386727f","after":null,"ref":"refs/heads/gh-readonly-queue/main/pr-13476-1ec5cdf3f2aac4d40cb641aa438531264cf4a0fe","pushedAt":"2024-05-22T18:27:06.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"}},{"before":"caf55d4e5f21c2b0acb186451c67fe3d00376360","after":null,"ref":"refs/heads/gh-readonly-queue/main/pr-13475-b572b48bc55e4c72de7c08d470c9864f0386727f","pushedAt":"2024-05-22T18:27:06.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEUn_63wA","startCursor":null,"endCursor":null}},"title":"Activity · bevyengine/bevy"}