Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAM - nuget references make no sense #3331

Open
cdhanna opened this issue Apr 23, 2024 · 0 comments
Open

SAM - nuget references make no sense #3331

cdhanna opened this issue Apr 23, 2024 · 0 comments
Assignees
Milestone

Comments

@cdhanna
Copy link
Collaborator

cdhanna commented Apr 23, 2024

    <!-- Nuget references -->
    <ItemGroup>
        <PackageReference Include="Beamable.Microservice.Runtime" Version="0.0.0-PREVIEW.NIGHTLY-202404221812" />
        
        <PackageReference Include="EmbedIO" Version="3.4.*" />
        <PackageReference Include="LoxSmoke.DocXml" Version="3.4.*" />
        <PackageReference Include="Microsoft.Extensions.DependencyInjection" Version="6.0.0-preview.6.21352.12" />
        <PackageReference Include="Microsoft.OpenApi" Version="1.6.3" />
        <PackageReference Include="Microsoft.OpenApi.Readers" Version="1.3.2" />
        <PackageReference Include="NetMQ" Version="4.0.1.11" />
        <PackageReference Include="Newtonsoft.Json" Version="13.0.*" />
        <PackageReference Include="Serilog" Version="2.10.*" />
        <PackageReference Include="Serilog.Formatting.Compact" Version="1.1.*" />
        <PackageReference Include="Serilog.Sinks.Console" Version="3.1.*" />
        <PackageReference Include="System.CommandLine" Version="2.0.0-beta3.22114.*" />
        <PackageReference Include="System.ServiceModel.Primitives" Version="4.9.*" />
        <PackageReference Include="System.Threading.RateLimiting" Version="7.0.0" />
    </ItemGroup>

Having this in the csproj goes against common nuget practice, because the beamable.microservice.runtime package should pull in its own dependencies, and we shouldn't rely on the customer csproj bringin the references that beamable.microservice.runtime needs.

The way to fix this is to REMOVE code and configuration files.

  1. remove the microservice/.nuspec file
  2. remove the references from the templates, because they won't be needed.
@cdhanna cdhanna added this to the Unity 2.0.0 milestone Apr 23, 2024
@cdhanna cdhanna self-assigned this May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant