Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI - Start discovery not getting microservice port correctly #3279

Closed
cdhanna opened this issue Apr 9, 2024 · 1 comment · Fixed by #3380
Closed

CLI - Start discovery not getting microservice port correctly #3279

cdhanna opened this issue Apr 9, 2024 · 1 comment · Fixed by #3380
Assignees
Milestone

Comments

@cdhanna
Copy link
Collaborator

cdhanna commented Apr 9, 2024

In the method DiscoveryService.StartDiscovery, we are trying to get the running microservice port in docker, like this:

healthPort = Convert.ToInt32(_localSystem.BeamoManifest.HttpMicroserviceRemoteProtocols[serviceDefinition.BeamoId]
					.HealthCheckPort);

However we should be doing something similar to what we do to get the mongo running containers port in the GetStorageHostPort method instead. We need the bound port, not the internal container port; because the internal container port is useless outside the container where the host command is running.

This is blocked by the issue CLI - services run not aways working since that prevents this from being tested.

@cdhanna cdhanna added this to the Unity 2.0.0 milestone Apr 9, 2024
@cdhanna
Copy link
Collaborator Author

cdhanna commented Apr 9, 2024

Currently blocked by #3270

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants