Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICC Saurfang combat start dialog with Muradin Bronzebeard are broken #8921

Open
zqgmzq opened this issue Nov 3, 2021 · 8 comments · May be fixed by #18931
Open

ICC Saurfang combat start dialog with Muradin Bronzebeard are broken #8921

zqgmzq opened this issue Nov 3, 2021 · 8 comments · May be fixed by #18931

Comments

@zqgmzq
Copy link

zqgmzq commented Nov 3, 2021

Current Behaviour

ICC Saurfang combat start dialog Muradin Bronzebeard are broken

Expected Blizzlike Behaviour

ICC Saurfang combat start dialog Muradin Bronzebeard is ok

Source

No response

Steps to reproduce the problem

Go ICC
Start batle with Saurfang

Extra Notes

No response

AC rev. hash/commit

bfe2904

Operating system

Debian 10

Custom changes or Modules

No response

@Shineslippers
Copy link

I guess he is mixing Horde/Allince text
WoWScrnShot_110421_185130

Wowwiki Saurfang quotes

@Azcobu Azcobu added this to To do in Content 60 via automation Nov 5, 2021
@Ravenguard13
Copy link

Another thing is - the ending of the fight is broken too.

After he dies, the Big Saurfang has to show up and take his son's body. Unfortunately, this script is absent, for both factions.

Not sure if i'm supposed to make a new topic about this or just say it here

@Ravenguard13
Copy link

@Azcobu it's "Content 80", not 60 ))))

@Shineslippers
Copy link

It's auto. Don't understand. I labled it 80.

@pangolp
Copy link
Contributor

pangolp commented May 2, 2024

If I make this query

UPDATE `creature` SET `id1`=37200 WHERE `guid`=200982;

The dialogue in the alliance is perfect.
Although I will surely fail in the horde.

I'm not saying that should be the answer.
But it's funny, how when you make that change, it "fixes itself"
I think the problem is in the Creature::UpdateEntry.
But I have already tried several times to find the solution and I have not been able to.

@pangolp
Copy link
Contributor

pangolp commented May 2, 2024

Another change I made was this.

uint32 Creature::GetScriptId() const
{
    if (CreatureData const* creatureData = GetCreatureData())
        if (uint32 scriptId = creatureData->ScriptId)
            return scriptId;

    return sObjectMgr->GetCreatureTemplate(GetEntry())->ScriptID;
}

For this

uint32 Creature::GetScriptId() const
{
    return sObjectMgr->GetCreatureTemplate(GetEntry())->ScriptID;
}

In this way, I have managed to ensure that the gossip is read properly.

WoWScrnShot_050224_141513

WoWScrnShot_050224_141530

@pangolp
Copy link
Contributor

pangolp commented May 2, 2024

2024-05-02.14-21-50.mp4

WoWScrnShot_050224_142407

@pangolp
Copy link
Contributor

pangolp commented May 3, 2024

I really don't know what else to try. On top of that I have a core from a few years ago, and this mechanic works well. I'm sure it has something to do with when the 3 ids were added to the creature table. But I have no way to reproduce the problem. I've already given up hope of being able to really track down the problem.

@pangolp pangolp linked a pull request May 20, 2024 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Content 80
  
To do
Development

Successfully merging a pull request may close this issue.

4 participants