Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Label track deleted after Tempo (or Time Signature)change and closing project (without saving) #6453

Open
LinkeHand opened this issue May 19, 2024 · 4 comments
Labels
bug An error, undesired behaviour, or missed functionality Labels P2 High priority regression Bug is a regression against previous version
Milestone

Comments

@LinkeHand
Copy link

LinkeHand commented May 19, 2024

Bug description

Make a tempo change in the time signature toolbar to a project with a label track.
Close the project without saving.
The label track is deleted.

The result is even worse than in issue #6166, where the label track is only not in sync.

Steps to reproduce

  1. Generate Track
  2. Add Label Track
  3. Save Project - Save to computer
  4. Close and reopen the file
  5. Change Tempo (or Time Signature) in the Time Signature Toolbar
  6. Close file - without saving
  7. Reopen file

Expected behavior

Closing a project does not change the project file at all.

Actual behavior

After Step 4:

DTMF_after save

After Step 5 - tempo changed:

DMTF_after tempo change

After Step 6 - reopened project file which was previously only closed without saving:

DMTF_after tempo change _close_reopen

Audacity Version

current master / alpha / nightly build

Operating system

Windows

Additional context

Tested with Audacity 3.6.0-alpha-20240514 (audacity-win-3.6.0-alpha-20240514+3af928c-x64-msvc2022.zip).

@LinkeHand LinkeHand added the bug An error, undesired behaviour, or missed functionality label May 19, 2024
@LinkeHand LinkeHand changed the title Label track deleted after tempo change and closing file (without saving) Label track deleted after tempo change and closing project (without saving) May 19, 2024
@petersampsonaudacity
Copy link

petersampsonaudacity commented May 19, 2024

Testing on W11 with the 3,6.0 Beta build:

I confirm this bug - the error also occurs if you change the Time Signature at @LinkeHand 's Step 5 (I updated the STRs and bug title).

And testing shows that it is a regression on 3.5.1

@petersampsonaudacity petersampsonaudacity added regression Bug is a regression against previous version Labels labels May 19, 2024
@petersampsonaudacity petersampsonaudacity changed the title Label track deleted after tempo change and closing project (without saving) Label track deleted after Tempo (or Time Signature)change and closing project (without saving) May 19, 2024
@petersampsonaudacity
Copy link

@dozzzzer

This issue (and it's close cousin #6166 ) are both pretty serious issues as thee involve "silent"/hidden data loss for the user. And as the loss occurs as the project is closed the data loss they may not be discovered by the user till much layer.

I think that these two bugs really deserve a fairly high P-rating, do you agree?

@dozzzzer dozzzzer added the P2 High priority label May 21, 2024
@LinkeHand
Copy link
Author

LinkeHand commented May 23, 2024

I made tests with try and error for bug #6453 (not #6166):

  • audacity-win-3.6.0-alpha-20240404+cccbd6c-x64-msvc2022 --> the label track is not deleted
  • audacity-win-3.6.0-alpha-20240404+983dc1b-x64-msvc2022 --> the label track is deleted

As far as I see, there is no further version between theese two builds. Perhaps it helps.

@LinkeHand
Copy link
Author

accidentally closed

@LinkeHand LinkeHand reopened this May 23, 2024
@dozzzzer dozzzzer added this to the Audacity 3.6 milestone May 24, 2024
@saintmatthieu saintmatthieu removed their assignment Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An error, undesired behaviour, or missed functionality Labels P2 High priority regression Bug is a regression against previous version
Projects
Status: To-Do
Development

No branches or pull requests

4 participants