Notification using old rollout/pre-trigger state?

[meeech]

Putting this out here in case someone has any insight, or has tried to deal with this in the past. I am digging into it, but hoping someone might have more context they can share.

Checklist:

• I've included steps to reproduce the bug.
• I've included the version of argo rollouts.

Describe the bug

Trying to make a webhook notification on analysis run fail.
What I've noticed is the contents of the rollout and status seem to be the 'old' generation, not the latest.
eg: I am expecting .rollout.status.message to have contents about failure, but instead it is "CanaryStepPaused". I can also see this reflected in the .rollout.metadata.resourceVersion where the resourceVersion i see output in the notif doesn't match the resourceVersion in the latest rollout. I see the same result when using on-rollout-aborted trigger.

To Reproduce

Fire off webhook notif (though I assume this happens in all notifs)

Expected behaviour

That the notification has the rollout object which reflects the state of the notification. eg; when the event is analysis-run-failed, i am expecting that info to be available to the notification.

Version

1.6.6

Logs

When I run in debug and step through, I notice this which comes after all the events have fired:

time="2024-04-21T20:59:20-04:00" level=info msg="persisted to informer" generation=2 namespace=default resourceVersion=562164 rollout=example-helm-rollout
time="2024-04-21T20:59:20-04:00" level=info msg="Reconciliation completed" generation=2 namespace=default resourceVersion=561754 rollout=example-helm-rollout time_ms=268028.84295799996

---

Message from the maintainers:

Impacted by this bug? Give it a 👍. We prioritize the issues with the most 👍.

[daftping]

We see the same behaviour. Unable to add failed reason to the notification using {{ .rollout.status.message }}, It shows the previous message more replicas need to be updated instead of an up-to-date message.