You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We are using Graphite as a metric provider, and in AnalysisTemplate we check for number of errors in last few minutes. When there are no errors from the component, graphite returns empty set. This is treated by provider as an error:
Empty set of errors is an indicator of lack of errors, so it should be ok.
Moreover, this is expected for other providers -- documentation mentions how to deal with empty sets and recommends including len(results) > 0 || … in successCondition. This workaround does not work with Graphite provider, due to hardcoded fail on empty results set.
To Reproduce
Have and Graphite-using AnalyzeTemplate with settings like:
Empty result set should be surfaced to AnalysisRun and interpreted there.
Screenshots
Version
Rollouts v1.6.6
Logs
# Paste the logs from the rollout controller
# Logs for the entire controller:
kubectl logs -n argo-rollouts deployment/argo-rollouts
# Logs for a specific rollout:
kubectl logs -n argo-rollouts deployment/argo-rollouts | grep rollout=<ROLLOUTNAME
Message: Metric "error-rate-ra-model" assessed Error due to consecutiveErrors (5) > consecutiveErrorLimit (4): "Error Message: no values found"
Message from the maintainers:
Impacted by this bug? Give it a 👍. We prioritize the issues with the most 👍.
The text was updated successfully, but these errors were encountered:
Checklist:
Describe the bug
We are using Graphite as a metric provider, and in
AnalysisTemplate
we check for number of errors in last few minutes. When there are no errors from the component, graphite returns empty set. This is treated by provider as an error:argo-rollouts/metricproviders/graphite/graphite.go
Lines 69 to 71 in 02d7e4f
Empty set of errors is an indicator of lack of errors, so it should be ok.
Moreover, this is expected for other providers -- documentation mentions how to deal with empty sets and recommends including
len(results) > 0 || …
insuccessCondition
. This workaround does not work with Graphite provider, due to hardcoded fail on empty results set.To Reproduce
Have and Graphite-using AnalyzeTemplate with settings like:
Expected behavior
Empty result set should be surfaced to AnalysisRun and interpreted there.
Screenshots
Version
Rollouts v1.6.6
Logs
Message: Metric "error-rate-ra-model" assessed Error due to consecutiveErrors (5) > consecutiveErrorLimit (4): "Error Message: no values found"
Message from the maintainers:
Impacted by this bug? Give it a 👍. We prioritize the issues with the most 👍.
The text was updated successfully, but these errors were encountered: