Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SIP-134] Hide inactive users #28569

Open
lyndsiWilliams opened this issue May 18, 2024 · 1 comment
Open

[SIP-134] Hide inactive users #28569

lyndsiWilliams opened this issue May 18, 2024 · 1 comment
Labels
change:frontend Requires changing the frontend sip Superset Improvement Proposal

Comments

@lyndsiWilliams
Copy link
Member

lyndsiWilliams commented May 18, 2024

[SIP-134] Proposal for Hide inactive users

Motivation

Some users don't want/need to see inactive users in the "Owners" dropdown in list views and on Superset entities.

Proposed Change

Use the isActive attribute to hide any users that are inactive on the front end. We can put this behind a config flag since some users do want to see inactive users.

New or Changed Public Interfaces

  • Any instances of the "Owners" dropdown will only show active users.
  • This will be toggled with a config flag so that users have the option to show or hide inactive users.

New dependencies

None.

Migration Plan and Compatibility

No changes here.

Rejected Alternatives

I'm unaware of any rejected alternatives.

@lyndsiWilliams lyndsiWilliams added the sip Superset Improvement Proposal label May 18, 2024
@dosubot dosubot bot added the change:frontend Requires changing the frontend label May 18, 2024
@rusackas rusackas changed the title [SIP] Hide inactive users [SIP-134] Hide inactive users Jun 4, 2024
@rusackas
Copy link
Member

rusackas commented Jun 4, 2024

What determines whether a user is active or inactive? Are there thresholds to be set as well?

Is it better to flag users as "inactive" rather than "isActive" assuming they're active by default, and may fall into some lapsed state? This may avoid having to run a migration to add "isActive" to all users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
change:frontend Requires changing the frontend sip Superset Improvement Proposal
Projects
Development

No branches or pull requests

2 participants