[Bug][Gitlab] Data scopes can have the same name.

[antoniomuso]

Search before asking

• I had searched in the issues and found no similar issues.

What happened

When you have two repositories in two different groups but with the same name, for example: firstgroup/website and secondgroup/website. The name assigned to the scopes config is the same, and you cannot distinguish one from the other.

What do you expect to happen

I expect that the group name will be added to the data scope ex

How to reproduce

You can reproduce by adding to repositories with the same name but in different GitLab groups.

Anything else

No response

Version

v0.21.0

Are you willing to submit PR?

• Yes I am willing to submit a PR!

Code of Conduct

• I agree to follow this project's Code of Conduct

[dosubot]

To address the issue of having two repositories in different GitLab groups with the same name resulting in identical data scope names, a detailed investigation is necessary. Please provide the specific steps you followed when adding the repositories and configuring the data scopes. Additionally, sharing any error messages or logs you encountered during this process would be immensely helpful. This information is crucial for accurately reproducing the issue and working towards a resolution.

Details

About Dosu
This response is meant to be useful and save you time. It is not meant to be a precise solution, but rather a starting point for your own research.

Help me be more useful! Please leave a 👍 if this is helpful and 👎 if it is irrelevant.

To continue the conversation, mention @dosu.

[Startrekzky]

Hi @antoniomuso , I think this one has been fixed in the latest v1.0.0-beta8 by adding the namespace before the repo name in the data scope configuration dialogue. Please give it a go.

[antoniomuso]

Startrekzky I tried to upgrade, but I don't see this fix on the v1.0.0-beta8

[Startrekzky]

Hi @antoniomuso , I tried in the v1.0.0-beta8. I didn't have repos with the same names, but I can confirm when selecting data scope, the group name is displayed.

Not sure if I have understood your question correctly.

[antoniomuso]

@Startrekzky I mean, when you add the data scope to the project, if you have two data scopes with the same name, I don't know which data scope I am adding.

[Startrekzky]

@antoniomuso I see, the group name is not displayed in the project connection's data scope list. Will fix it later.

[klesh]

We've identified a potential issue with the config-ui component's reliance on the optional field scope.fullName within the API response. This inconsistency can affect not only Gitlab but also potentially other integrations.

Currently, the behavior of scope.fullName depends on the implementation of individual plugins, leading to potential errors. We're exploring solutions to address this:

1. Enforce fullName in Plugins: We could require all plugins to include fullName in the scope entity. This ensures consistency but requires modifying a significant number of plugins and maintaining compatibility.
2. Modify scopeHelper to Inject fullName or Response Format: We could modify the scope helper to inject value for fullName or redesign the entire response format.

Both options require careful consideration and thorough testing. We're actively evaluating the best approach and will keep you updated.

In the meantime, if you have any questions or suggestions, feel free to comment below!