Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement][Master] Add master explicit overload control like worker #16032

Open
3 tasks done
pegasas opened this issue May 20, 2024 · 1 comment · May be fixed by #16034
Open
3 tasks done

[Improvement][Master] Add master explicit overload control like worker #16032

pegasas opened this issue May 20, 2024 · 1 comment · May be fixed by #16034
Labels
improvement make more easy to user or prompt friendly

Comments

@pegasas
Copy link
Contributor

pegasas commented May 20, 2024 •
edited

Search before asking

  • I had searched in the issues and found no similar feature requirement.

Description

Now master/worker are all based on cpu/memory control in protection. see

dolphinscheduler/dolphinscheduler-meter/src/main/java/org/apache/dolphinscheduler/meter/metrics/BaseServerLoadProtection.java

Line 38 in 5463d02

public boolean isOverload(SystemMetrics systemMetrics) {

When deployed in k8s, it will get cpu/memory from pod node instead of pod JVM.
Add a explicit overload control like worker.

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!

Code of Conduct
@pegasas pegasas added improvement make more easy to user or prompt friendly Waiting for reply Waiting for reply labels May 20, 2024
@pegasas pegasas linked a pull request May 20, 2024 that will close this issue
Open
@ruanwenjun
Copy link
Member

Right now, we have not support get the pod cpu/memory, this need to be implemented.

@SbloodyS SbloodyS removed the Waiting for reply Waiting for reply label May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
improvement make more easy to user or prompt friendly
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Improvement][Master] Add master explicit overload control pegasas/dolphinscheduler
3 participants
@pegasas @SbloodyS @ruanwenjun