Cron module fails without error message

[jackfarzan]

Summary

When I try to provision a cron job with the cron module, the task fails but doesn't give an error message.

Issue Type

Bug Report

Component Name

cron

Ansible Version

$ ansible --version                                                                                                                                                           
ansible [core 2.16.5]
  config file = None
  configured module search path = ['/home/jenkins/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/local/lib/python3.10/dist-packages/ansible
  ansible collection location = /home/jenkins/.ansible/collections:/usr/share/ansible/collections
  executable location = /usr/local/bin/ansible
  python version = 3.10.12 (main, Nov 20 2023, 15:14:05) [GCC 11.4.0] (/usr/bin/python3)
  jinja version = 3.1.3
  libyaml = True

Configuration

$ ansible-config dump --only-changed -t all                                                                                                                                   
WARNING: terminal is not fully functional
Press RETURN to continue 
CONFIG_FILE() = None

OS / Environment

MacOS 13.2.1

Steps to Reproduce

    - name: "Implement daily tmp removal cron"
      ansible.builtin.cron:
        name: "rm tmp dirs"
        minute: "5"
        hour: "1"
        job: "rm -rf /Users/my-user/tmp-*"

Expected Results

I expect cron to be updated, or to return a useful error message.

Actual Results

fatal: [x.x.x.x]: FAILED! => changed=false 
  invocation:
    module_args:
      backup: false
      cron_file: null
      day: '*'
      disabled: false
      env: false
      hour: '1'
      insertafter: null
      insertbefore: null
      job: rm -rf /Users/my-user/tmp-*
      minute: '5'
      month: '*'
      name: rm tmp dirs
      special_time: null
      state: present
      user: null
      weekday: '*'
  msg: ''

Code of Conduct

• I agree to follow the Ansible Code of Conduct

[ansibot]

Files identified in the description:

• lib/ansible/modules/cron.py

If these files are incorrect, please update the component name section of the description or use the component bot command.

[flowerysong]

The only code path I see that could plausibly result in this is

ansible/lib/ansible/modules/cron.py

Lines 327 to 328 in 8ad68f1

	if rc != 0:
	self.module.fail_json(msg=err)

Does changing that line to self.module.fail_json(msg=err, stdout=out, rc=rc) provide any useful information?

[jackfarzan]

Unfortunately not:

fatal: [10.32.239.40]: FAILED! => changed=false 
  invocation:
    module_args:
      backup: false
      cron_file: null
      day: '*'
      disabled: false
      env: false
      hour: '1'
      insertafter: null
      insertbefore: null
      job: rm -rf /Users/my-user/tmp-*
      minute: '5'
      month: '*'
      name: rm tmp dirs
      special_time: null
      state: present
      user: null
      weekday: '*'
  msg: ''
  rc: -9
  stdout: ''
  stdout_lines: <omitted>

I'm guessing it's crontab itself that isn't returning any useful error.

[jackfarzan]

Having the rc is a little bit more useful than absolutely nothing though - can I make a PR?

[mkrizek]

Having the rc is a little bit more useful than absolutely nothing though - can I make a PR?

Sure, thanks!

[jackfarzan]

PR opened!