Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Deserialization on BigDecimal #2582

Closed
Cooper-Zhong opened this issue May 16, 2024 · 3 comments
Closed

[BUG] Deserialization on BigDecimal #2582

Cooper-Zhong opened this issue May 16, 2024 · 3 comments
Assignees
Labels
bug Something isn't working fixed
Milestone

Comments

@Cooper-Zhong
Copy link

问题描述

反序列化BigDecimal时变成了负数,fastjson 1.2.83无此问题

环境信息

  • OS信息: [MacOS 12.7.4 M1 Pro 16 GB]
  • JDK信息: [Openjdk 17.0.6]
  • 版本信息:[Fastjson2 2.0.50]

重现步骤

import com.alibaba.fastjson2.JSON;
import org.junit.jupiter.api.Test;

import java.math.BigDecimal;

import static org.junit.jupiter.api.Assertions.assertEquals;

public class Issue1204Mutated_504 {
    @Test
    public void testMutated() throws Exception {
        BigDecimal decimal = BigDecimal.valueOf(Long.MAX_VALUE).add(BigDecimal.ONE);
        String str = JSON.toJSONString(decimal);
        assertEquals("9223372036854775808", str);
        BigDecimal decimal1 = (BigDecimal) JSON.parseObject(str,BigDecimal.class);
        assertEquals(decimal.stripTrailingZeros(), decimal1);
    }
    
    @Test
    public void testMutated1() throws Exception {
        BigDecimal decimal = BigDecimal.valueOf(Long.MAX_VALUE).add(BigDecimal.TEN);
        String str = JSON.toJSONString(decimal);
        assertEquals("9223372036854775817", str);
        BigDecimal decimal1 = (BigDecimal) JSON.parseObject(str,BigDecimal.class);
        assertEquals(decimal.stripTrailingZeros(), decimal1);
    }

    @Test
    public void testMutate1() throws Exception {
    // 1.2.83
        BigDecimal decimal = BigDecimal.valueOf(Long.MAX_VALUE).add(BigDecimal.ONE);
        String str = com.alibaba.fastjson.JSON.toJSONString(decimal);
        assertEquals("9223372036854775808", str);
        BigDecimal decimal1 = (BigDecimal) com.alibaba.fastjson.JSON.parseObject(str,BigDecimal.class);
        assertEquals(decimal.stripTrailingZeros(), decimal1);
    }
}

期待的正确结果

9223372036854775808

相关日志输出

org.opentest4j.AssertionFailedError:
Expected :9223372036854775808
Actual :-9223372036854775808

@Cooper-Zhong Cooper-Zhong added the bug Something isn't working label May 16, 2024
@yanxutao89 yanxutao89 self-assigned this May 16, 2024
@wenshao wenshao added this to the 2.0.51 milestone May 16, 2024
@wenshao
Copy link
Member

wenshao commented May 16, 2024

https://oss.sonatype.org/content/repositories/snapshots/com/alibaba/fastjson2/fastjson2/2.0.51-SNAPSHOT/
问题已修复,请帮忙用2.0.51-SNAPSHOT版本验证

@wenshao wenshao added the fixed label May 16, 2024
@Cooper-Zhong
Copy link
Author

验证已修复,辛苦温少

@wenshao
Copy link
Member

wenshao commented Jun 1, 2024

https://github.com/alibaba/fastjson2/releases/tag/2.0.51
问题已修复,请用新版本

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixed
Projects
None yet
Development

No branches or pull requests

3 participants