Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content Reordering potion doesn’t work in Firefox #30

Open
adamschwartz opened this issue Jul 15, 2016 · 4 comments
Open

Content Reordering potion doesn’t work in Firefox #30

adamschwartz opened this issue Jul 15, 2016 · 4 comments

Comments

@adamschwartz
Copy link
Owner

Reported by https://twitter.com/MattTams/status/753619416223457280

@afzalsayed96
Copy link

Hey, this is an awesome project and I would love to contribute :) Where can I start?

@adamschwartz
Copy link
Owner Author

adamschwartz commented Nov 29, 2017

Hey @afzalsayed96 thanks so much!

This potion should either be removed or re-written to use the CSS flex and order properties rather than the <ruby> element. Taking a crack at that would be a great way to start.

@afzalsayed96
Copy link

Hi @adamschwartz thanks for your response!
I tried to find a work around for this issue and figured that adding the following code helps.

.example-ruby .simulate-section .simulate-div {
    display: block;
    padding: .5em 1em;
+   white-space: pre-line;
+   word-break: break-all;
+   word-wrap: break-word;
+   overflow-x: auto;
}
.example-ruby rt {
    font-size: inherit;
+   margin: 10em auto;
}

What do you think?

@adamschwartz
Copy link
Owner Author

I appreciate the effort! But in light of this recent HN thread I decided it was probably overdue to we start recommending flex for content ordering instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants