-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARC Finalizers Cause a deadlock when uninstalling AutoscalingRunnerSet in ArgoCD #3440
Comments
I was successfully able to fix the issue using argocd annotations |
@nikola-jokic could I trouble you for your two cents on this? |
@rteeling-evernorth Thanks for making an issue for this - I've run into this issue on nearly every upgrade and end up having to turn off syncing, manually delete the finalizers, and then turn syncing back on and it ends up sorting itself out. I also have noticed that even if a new controller comes up (say I do use
Looking at your PR you set |
@ahatzz11 Had the same issue with having to manually resolve the finalizer deadlock. I've installed the controller in an entirely separate ArgoCD app, since the cardinality of the scale set controller to scale sets is 1:N. I assume GitHub is distributing the controller and runner set charts separately because of this. You should separate them into separate ArgoCD apps for the sake of ease of maintenance if nothing else. Argo Sync waves are only relevant within the context of an Argo App, so as long as the two charts are managed by separate apps, you won't see any conflict. Once this is done you just uninstall any app for the scale set, then uninstall the controller and you won't have any deadlock issues. Hope that helps! |
@rteeling-evernorth Cool thanks for the explanation - I do have each chart managed as separate apps so we should be good to go there! |
What are your thoughts on this issue and corresponding PR? |
@nikola-jokic @Link- Is it possible to get this issue/PR looked at for the next release? It would be awesome to have upgrades massively simplified for argocd users. |
Thanks for adding the appropriate labels. It's on our radar now. |
@ahatzz11 did my change work for you? I'd prefer to not cause an "It works on my machine" sort of problem. |
@Link- @nikola-jokic Just curious - what's going on with this? The associated PR has been sitting in the hopper for a while now, is there anything i can do within reason to help get this released? |
Checks
Controller Version
0.9.0
Deployment Method
ArgoCD
Checks
To Reproduce
Describe the bug
The argocd app cannot be deleted because Argo tries to delete resources that are normally deleted by the ARC controller and normal deletion is blocked by the
actions.github.com/cleanup-protection
finalizerincluding:
Describe the expected behavior
The chart should cleanly uninstall when i delete the argocd app
Additional Context
I suspect this may be resolvable by helm/argo annotations for the affected resources, I will test with a fork of the helm chart
Controller Logs
My employer's open source contribution policy forbids me from creating public Gists. I will provide redacted logs upon request via zip/tarball.
Runner Pod Logs
My employer's open source contribution policy forbids me from creating public Gists. I will provide redacted logs upon request via zip/tarball.
The text was updated successfully, but these errors were encountered: