chore: workflows call workflows #7089
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| ignore-push: | ||
| description: 'Ignore push to dockerhub. If not set the image will be pushed with the sha of the commit as tag' | ||
| required: false | ||
| type: boolean |
There was a problem hiding this comment.
Removed the ability of ignoring pushes. We never use it, it was mainly for testing this workflow during development
| @@ -6,14 +6,8 @@ on: | |||
| - main | |||
| paths-ignore: | |||
| - website/** | |||
| tags: | |||
| - 'v*' | |||
| workflow_call: | |||
There was a problem hiding this comment.
Instead of relying on tags, publish docker from the release workflow: https://github.com/Unleash/unleash/pull/7089/files#diff-c15c3b26808da8f11c4b99dba3911b9ded250104a2c8991073e1993e90444612R111
| type=semver,pattern={{ version }},enable=${{ github.event_name == 'workflow_dispatch' && github.ref != 'refs/heads/main' }} | ||
| type=semver,pattern={{ major.minor }},enable=${{ github.event_name == 'workflow_dispatch' && github.ref != 'refs/heads/main' }} | ||
| type=semver,pattern={{ major }},enable=${{ github.event_name == 'workflow_dispatch' && github.ref != 'refs/heads/main' }} |
There was a problem hiding this comment.
We can't check that the ref starts with tags because the ref will be the one of the branch we're releasing from. Instead, whenever this workflow is called will tag the image with semver, except when called from main (cause we're not releasing from main)
| push: | ||
| tags: | ||
| - 'v*' | ||
| workflow_call: |
There was a problem hiding this comment.
Publishing to npm based on a workflow call. If we want to still publish on tag we can add workflow_dispatch to call this manually
| @@ -1,4 +1,4 @@ | |||
| name: 'Releases' | |||
| name: 'Release changelog' | |||
There was a problem hiding this comment.
Just a rename. Keeping this workflow relying on tags because it uses a deprecated action and relies on tag refs. We should migrate this: https://github.com/Unleash/unleash/actions/runs/9125610662/job/25092161594#step:4:3
gastonfournier
force-pushed
the
workflow-dependencies
branch
from
2add892
to
f2bc0d5
Compare
| @@ -35,10 +34,10 @@ jobs: | |||
| images: | | |||
| unleashorg/unleash-server | |||
| tags: | | |||
| # only enabled for v* tags: | |||
| type=semver,pattern={{ version }},enable=${{ startsWith(github.ref, 'refs/tags/v') }} | |||
| type=semver,pattern={{ major.minor }},enable=${{ startsWith(github.ref, 'refs/tags/v') }} | |||
There was a problem hiding this comment.
pattern={{ major.minor }} was wrong, it should be pattern={{ major }}.{{ minor }}
| # only enabled for workflow dispatch except main (assume its a release): | ||
| type=semver,pattern={{ version }},enable=${{ github.event_name == 'workflow_dispatch' && github.ref != 'refs/heads/main' }},value=${{ inputs.version }} | ||
| type=semver,pattern={{ major }}.{{ minor }},enable=${{ github.event_name == 'workflow_dispatch' && github.ref != 'refs/heads/main' }},value=${{ inputs.version }} | ||
| type=semver,pattern={{ major }},enable=${{ github.event_name == 'workflow_dispatch' && github.ref != 'refs/heads/main' }},value=${{ inputs.version }} |
There was a problem hiding this comment.
Now we explicitly send the value as in https://github.com/ivarconr/unleash-enterprise/pull/1316 (because we're not using the tag to trigger)
| - name: Get the version | ||
| id: get_version | ||
| run: echo ::set-output name=VERSION::${GITHUB_REF/refs\/tags\//} |
There was a problem hiding this comment.
We can't get the version from the tag, but we can receive it as an input parameter
| - name: Publish static assets to S3 | ||
| run: | | ||
| aws s3 cp frontend/build s3://getunleash-static/unleash/${{ steps.get_version.outputs.VERSION }} --recursive | ||
| aws s3 cp frontend/build s3://getunleash-static/unleash/v${{ inputs.version }} --recursive |
There was a problem hiding this comment.
Make sure to prepend v as that's what we used to get from the tag, but the version number is just the semver without the leading v.
Compared in this test https://github.com/gastonfournier/unleash/actions/runs/9161953548/job/25187925675#step:8:8 against an actual release from unleash: https://github.com/Unleash/unleash/actions/runs/9110390951/job/25045331871#step:8:1
| - name: Create release | ||
| uses: actions/create-release@v1 | ||
| uses: softprops/action-gh-release@v2 |
There was a problem hiding this comment.
Upgrading to the same action we're using in enterprise as the one at the left is archived
| with: | ||
| version: ${{ github.event.inputs.version }} | ||
|
|
||
| release-changelog: # TODO this changelog is different than the git-cliff one above |
There was a problem hiding this comment.
TODO: I'd like to tackle this later but I want to highlight this for the reviewer
gastonfournier
force-pushed
the
workflow-dependencies
branch
from
b935c6d
to
850f69f
Compare
Relying on tags to trigger workflows makes it hard to trace what's happening after a release, currently:
This creates a loose dependency between the workflows which are actually part of the same "release workflow" which makes it difficult to spot when one or other dependent workflow fails because the dependency is indirect through the tagging mechanism.
This PR switches to a more direct approach using workflow calls. This will create a graph as shown in the following graph:
making it easier to track and identify any problem.
The "drawback" of this approach is that previously we could trigger all dependent workflows at once by creating a tag matching the expected pattern without manually triggering a new release. This limitation can be overcome by adding a manual workflow_dispatch to the workflows using the tag trigger.