Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request] Exclude "Samples" folder from the repository #477

Open
IsaiahKelly opened this issue Jul 10, 2021 · 2 comments
Open

[Request] Exclude "Samples" folder from the repository #477

IsaiahKelly opened this issue Jul 10, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@IsaiahKelly
Copy link
Contributor

I have been getting annoying console warnings related to the localization samples, which can be easily ignored. However, yesterday when opening the project I was prompted to enter "safe mode" due to errors, which was very odd considering I had not changed anything in the project since the last time it was opened and working fine.

After investigating this a little it appeared the localization samples were the cause? I don't know the exact reason for this, but I would highly recommend you exclude the package "Samples" folder altogether anyway. Since it doesn't contain anything essential and is only likely to create more annoyances like this for me and others in the future. At the very least it's inclusion in the project is unnecessary and only adds needless extra "noise".

@ciro-unity
Copy link
Contributor

However, yesterday when opening the project I was prompted to enter "safe mode" due to errors, which was very odd considering I had not changed anything in the project since the last time it was opened and working fine.

Out of curiosity: were you using the Hub v3.0.0 (Beta) when this happened?

In any case I agree we should remove them.

@ciro-unity ciro-unity added bug (minor) The game could potentially ship with this bug enhancement New feature or request and removed bug (minor) The game could potentially ship with this bug labels Jul 15, 2021
@IsaiahKelly
Copy link
Contributor Author

Out of curiosity: were you using the Hub v3.0.0 (Beta) when this happened?

I don't remember, but the error was pointing to the samples folder in any case. So removing the samples would have most likely prevented this error, even if it was related to the Hub beta.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants