Hotfix for Issue #383 - Slime Critter Pushing Player Excessively #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
amel-unity
added
the
bug (important)
This was
linked to
issues
Apr 15, 2021
|
Hi @asb9599, thank you for opening this PR. I wanted to mention it here in case you haven't seen the updates on the 2 linked issues:
Thank you |
amel-unity
added
?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugfix for issues #383 and #349: Forum Thread
This issue was caused by the player and Slime colliders overlapping after the player's hit reaction plays, causing it to be pushed backward. The simple fix for this was to simply stop the Slime from moving forward during its attack if it already hit the player. For starters, I created a UnityEvent to be called during successful hit in OnTriggerEnter for the Attack class. Then on the Slime prefab I linked the UnityEvent to call a public method in the SlimeAttackController that simply stops the timer that controls its positional updates during its attack.
This can be tested by getting attacked by a Slime while up against the short rocks near the house in the TestingGround scene, the player is no longer pushed upwards and maintains its position after hit reaction finishes