Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible Error in BoidsSystem that surprisingly does not breake the simulation. #271

Open
piotrrach opened this issue Oct 4, 2023 · 0 comments

Comments

@piotrrach
Copy link

I've been analyzing BoidSystem and got to realization that there is a possible mistake in MergeCells job. In the ExecuteNext method to be precise. I suppose instead of this:

        public void ExecuteNext(int cellIndex, int index)
        {
            cellCount[cellIndex]      += 1;
            cellAlignment[cellIndex]  += cellAlignment[cellIndex];
            cellSeparation[cellIndex] += cellSeparation[cellIndex];
            cellIndices[index]        = cellIndex;
        }

should it be like this:

       public void ExecuteNext(int cellIndex, int index)
        {
            cellCount[cellIndex]      += 1;
            cellAlignment[cellIndex]  += cellAlignment[index];
            cellSeparation[cellIndex] += cellSeparation[index];
            cellIndices[index]        = cellIndex;
        }
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant