Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

world noise does not blend well with region corners or edges #352

Open
Xtarsia opened this issue Apr 17, 2024 · 1 comment
Open

world noise does not blend well with region corners or edges #352

Xtarsia opened this issue Apr 17, 2024 · 1 comment
Labels
enhancement New feature or request low priority Low Priority

Comments

@Xtarsia
Copy link
Contributor

Xtarsia commented Apr 17, 2024

Terrain3D version

v0.9.1

System information

Godot v4.2.1.stable - Windows 10.0.19045 - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 2080 SUPER (NVIDIA; 31.0.15.4617) - AMD Ryzen 7 3700X 8-Core Processor (16 Threads)

Is the issue reproducable in the demo?

Yes

Issue description

image
worst case scenario
image

what I would expect is that world noise blends with the height a region edges (as best can be done)

potential solution: the world noise function could check if it has a region neighbor in all 4 direction, and if a neighbor is present then perform an extra height read at the border, and blend to that.

Logs

No response

@Xtarsia Xtarsia changed the title world noise does not blend well with region corners world noise does not blend well with region corners or edges Apr 17, 2024
@TokisanGames
Copy link
Owner

Looking at it again, I think it works as expected.

Case 1, player standing in the middle of terrain. - The world noise is a visual gimmick only. There is no collision and there won't be until we make a terrain generator.

Case 2, hard edges. It blends in fine when the user does not put hard edges on the edge of their sculpt, and the world_noise_blend_near and _far are adjusted to blend in.

what I would expect is that world noise blends with the height a region edges (as best can be done)

The shader is not going to adjust the height data, which is what the ground collision is built off of.

With the blending parameters and the user smoothing their edges, I think it's fine. It's an expensive gimmick that I only want to use for demos anyway. I don't recommend it for games.

potential solution: the world noise function could check if it has a region neighbor in all 4 direction, and if a neighbor is present then perform an extra height read at the border, and blend to that.

If you want to try, fine, but I think our efforts would be better spend making a noise generator with erosion that will allow collision generation in #101 and gpu painting in #174

@TokisanGames TokisanGames added enhancement New feature or request low priority Low Priority labels Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request low priority Low Priority
Projects
None yet
Development

No branches or pull requests

2 participants